Ensure unique keys inside EntryMapAdapter#254
Conversation
This closes #253
kwin
force-pushed
the
bugfix/ensure-unique-keys-in-entrymapadapter
branch
from
efccaea to
1a5adb5
Compare
|
|
Isn't this just fixing the symptom, and at the same time hiding the possible problem of double loaded component? |
|
I think instead of silently ignoring as before this logs duplicates now proactively. I fail to see how this is worse than before. |
|
Logs, ok, but does it also remove duplicates? As if removes, this is breaking change: components (duplicates) may be now gone and nothing user can do about that. |
|
Relying on duplicates within a map is clearly violating the API contract so I don't think we need to support it (even if previously this was working by accident). |
|
Well, IF sisu did this since its inception, then WE CANNOT fix this in 1.0.1. So, I'd rather change this PR to log warnings but do not alter behaviour in any other way. Moreover, I have concerns this is by design. Also, are you sure this is Sisu and not Plexus? From where does duplicates come from? One important difference between Sisu and Plexus-Shim is that former is "flat" while latter does factor in visibility by Realms. So, it is quite possible that with this change you'd break something somewhere in some Plexus component... So yes, Map interface says that, but I think this is intentional design choice, after all, you do have duplicates in your system, and Sisu is not Realm aware. |
2 participants
This closes #253