Skip to content

[1627] Invalid textual import/export of LiteralRational#1633

Merged
AxelRICHARD merged 1 commit into
eclipse-syson:mainfrom
adaussy:ada/fix/1627
Oct 31, 2025
Merged

[1627] Invalid textual import/export of LiteralRational#1633
AxelRICHARD merged 1 commit into
eclipse-syson:mainfrom
adaussy:ada/fix/1627

Conversation

@adaussy

@adaussy adaussy commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Bug: #1627

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

bd.intValueExact();
type = "LiteralInteger";
} catch (final ArithmeticException e) {
// There is a bug in AST provided by SysIDE, the literal drop the

@AxelRICHARD AxelRICHARD Oct 31, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the sentence is not finished

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Bug: eclipse-syson#1627
Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
@AxelRICHARD AxelRICHARD merged commit feddbed into eclipse-syson:main Oct 31, 2025
3 checks passed
@adaussy adaussy deleted the ada/fix/1627 branch November 3, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid textual import/export of LiteralRational

2 participants