Skip to content

[2250] Leverage the selection dialog to improve the assume and require constraints#2253

Merged
AxelRICHARD merged 1 commit into
mainfrom
gco/enh/requirement-constraint-improvement
Jun 10, 2026
Merged

[2250] Leverage the selection dialog to improve the assume and require constraints#2253
AxelRICHARD merged 1 commit into
mainfrom
gco/enh/requirement-constraint-improvement

Conversation

@gcoutable

@gcoutable gcoutable commented Jun 4, 2026

Copy link
Copy Markdown
Member

Bug: #2250
Signed-off-by: Guillaume Coutable guillaume.coutable@obeo.fr

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@gcoutable gcoutable added this to the 2026.7.0 milestone Jun 4, 2026
@gcoutable gcoutable marked this pull request as ready for review June 4, 2026 08:03
@gcoutable gcoutable force-pushed the gco/enh/requirement-constraint-improvement branch 3 times, most recently from 42e7ce9 to c76ccee Compare June 8, 2026 08:52
@pcdavid pcdavid self-assigned this Jun 9, 2026

@pcdavid pcdavid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this somehow broke the "Show content as tree" (at least on a requirement node). Below, the right side is current master and the left side is a local instance with this change:

Capture.video.du.2026-06-10.10-07-13.mp4

Comment thread CHANGELOG.adoc Outdated
Comment thread doc/content/modules/user-manual/pages/release-notes/2026.7.0.adoc Outdated
@gcoutable gcoutable force-pushed the gco/enh/requirement-constraint-improvement branch 2 times, most recently from 425d0f9 to 00e5121 Compare June 10, 2026 12:43
@gcoutable

Copy link
Copy Markdown
Member Author

It looks like this somehow broke the "Show content as tree" (at least on a requirement node). Below, the right side is current master and the left side is a local instance with this change:

It was happening because the element was not exposed, and thus the graphical node was not created at all, thus show content as tree was not able to make the node visible.
I updated the PR to expose the element with the hidden state.
Now the show content as tree can make the element owned by a RequirementConstraintMembership visible.

…e constraints

Bug: #2250
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@gcoutable gcoutable force-pushed the gco/enh/requirement-constraint-improvement branch from 00e5121 to 42357f1 Compare June 10, 2026 13:50
@AxelRICHARD AxelRICHARD merged commit 8dbc160 into main Jun 10, 2026
4 of 5 checks passed
@AxelRICHARD AxelRICHARD deleted the gco/enh/requirement-constraint-improvement branch June 10, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Leverage the selection dialog to improve the assume and require constraints

3 participants