WIP Openshift support#106
Draft
jfaltermeier wants to merge 7 commits into
Draft
Conversation
jfaltermeier
force-pushed
the
jf/openshift
branch
2 times, most recently
from
bea16d5 to
93e8359
Compare
jfaltermeier
force-pushed
the
jf/openshift
branch
from
93e8359 to
d611dc3
Compare
* Create theia-cloud-sessions ServiceAccount for session pods (all providers) * Create anyuid SCC RoleBinding for OpenShift to allow any UID in session pods
* add Route resources for the landing page, service, and session routing template * disable Ingress templates when operator.cloudProvider is OPENSHIFT * grant the operator RBAC permission to manage route.openshift.io/routes
* replace the static session Route template with an openshift-route-config ConfigMap carrying TLS and annotation settings for the operator * fail Helm rendering when OPENSHIFT is combined with hosts.usePaths: true * only grant route.openshift.io permissions in the base chart when cloudProvider is OPENSHIFT
* wrap theia-cloud-ca-certificate.yaml and clusterissuer-selfsigned.yaml
in {{- if .Values.issuerca.enable }} guards
jfaltermeier
force-pushed
the
jf/openshift
branch
from
d611dc3 to
c4072ef
Compare
* only render pullSecret in the AppDefinition when it is set * document the value as optional and leave it unset for public registries; matches the existing pattern used for the other imagePullSecret fields (landing-page, operator, service)
jfaltermeier
force-pushed
the
jf/openshift
branch
from
a6555a6 to
d7d0cf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related eclipse-theia/theia-cloud#486