Make oauth2-proxy image configurable via --oAuth2ProxyImage#492
Make oauth2-proxy image configurable via --oAuth2ProxyImage#492Krutskik wants to merge 1 commit into
Conversation
|
Hi @Krutskik , thanks for the contribution ❤️ |
|
Hi @lucas-koehler ! |
|
Hi @lucas-koehler ! I signed the agreement 😊 |
|
Hi @Krutskik , thanks for signing this and the Helm repo PR. I'll review both later this week |
lucas-koehler
left a comment
There was a problem hiding this comment.
Hi @Krutskik,
the changes LGTM! Thanks for the contribution ❤️
I'll merge this together with the Helm change once it is approved, too :)
What it does
Closes #490
The operator previously hardcoded the
quay.io/oauth2-proxy/oauth2-proxyregistryin
templateDeployment.yaml, allowing only the tag to be configured via--oAuth2ProxyVersion. This prevented deploying Theia Cloud in air-gapped orcorporate networks where images must be pulled from a private registry
(e.g. Nexus, Artifactory).
This PR adds a new operator argument
--oAuth2ProxyImagethat overrides the fullimage path (registry + repository) for the oauth2-proxy container, while
--oAuth2ProxyVersioncontinues to control the tag.Changes
TheiaCloudOperatorArguments: new--oAuth2ProxyImageoption(default
quay.io/oauth2-proxy/oauth2-proxy), plus getter and updatedhashCode/equals/toString.DefaultDeploymentTemplateReplacements: newplaceholder-oauth2-proxy-imageplaceholder, populated from the new argument in both
getReplacementsmethods.templateDeployment.yaml: image line changed fromquay.io/oauth2-proxy/oauth2-proxy:placeholder-oauth2-proxy-versionto
placeholder-oauth2-proxy-image:placeholder-oauth2-proxy-version.CHANGELOG.md: added entry under Unreleased.Backwards compatibility
Fully backwards compatible. The default value reproduces the previous behavior,
so existing deployments are unaffected. Users in restricted networks can now set
e.g.
--oAuth2ProxyImage=nexus.corp.local/oauth2-proxy/oauth2-proxy.Follow-up
The Helm chart lives in the separate repository. A companion
change is needed there to expose this as a value (e.g.
operator.oAuth2ProxyImage)and pass it through to the operator. Happy to open that PR as well.