Skip to content

feat(binding_mqtt): support MQTT URI scheme#60

Draft
JKRhb wants to merge 4 commits into
mainfrom
mqtt-uri-scheme
Draft

feat(binding_mqtt): support MQTT URI scheme#60
JKRhb wants to merge 4 commits into
mainfrom
mqtt-uri-scheme

Conversation

@JKRhb

@JKRhb JKRhb commented Jul 21, 2023

Copy link
Copy Markdown
Member

This PR adds support for the use of the MQTT URI scheme that is currently being discussed in w3c/wot-binding-templates#292.

An open question here is how to deal with the topic vocabulary term. With the implementation in this PR, it is being treated as an "override", but maybe it also becomes obsolete when the new URI scheme is in place.

@JKRhb
JKRhb force-pushed the mqtt-uri-scheme branch 2 times, most recently from e5c9360 to 1d9ece4 Compare July 21, 2023 14:47
@codecov

codecov Bot commented Jul 24, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -8.25% ⚠️

Comparison is base (1fd9a64) 60.41% compared to head (d8e8744) 52.16%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   60.41%   52.16%   -8.25%     
==========================================
  Files          70       70              
  Lines        2185     2189       +4     
==========================================
- Hits         1320     1142     -178     
- Misses        865     1047     +182     
Files Changed Coverage Δ
lib/src/binding_mqtt/mqtt_extensions.dart 0.00% <0.00%> (ø)

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-commenter

codecov-commenter commented Dec 23, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.22%. Comparing base (fc3d0a6) to head (47a23d3).
⚠️ Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/binding_mqtt/mqtt_extensions.dart 0.00% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   63.34%   63.22%   -0.12%     
==========================================
  Files          78       78              
  Lines        2275     2279       +4     
==========================================
  Hits         1441     1441              
- Misses        834      838       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JKRhb
JKRhb force-pushed the mqtt-uri-scheme branch 2 times, most recently from d5a6b06 to 9113b47 Compare January 5, 2024 04:18
@JKRhb
JKRhb force-pushed the mqtt-uri-scheme branch from 40eaea2 to 37904df Compare April 28, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants