Merge branch 'issue-1430-typescript-eslint-no-floating-promises' of https://github.com/danielpeintner/thingweb.node-wot into danielpeintner-issue-1430-typescript-eslint-no-floating-promises

Author: relu91

eslint.config.mjs

@@ -124,7 +124,7 @@ export default defineConfig([
             "@typescript-eslint/no-require-imports": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
             "@typescript-eslint/prefer-nullish-coalescing": "error",
             "@typescript-eslint/no-empty-object-type": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
-            "@typescript-eslint/no-floating-promises": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
+            "@typescript-eslint/no-floating-promises": "error",
 
             // ****************  Enforce usage of `const` over `let` wherever possible, to prevent accidental reassignments
             "prefer-const": "error",

packages/core/src/consumed-thing.ts

@@ -288,7 +288,7 @@ class InternalEventSubscription extends InternalSubscription {
 
         const formWithoutURIvariables = handleUriVariables(this.thing, te, form, options);
         debug(`ConsumedThing '${this.thing.title}' unsubscribing to ${form.href}`);
-        this.client.unlinkResource(formWithoutURIvariables);
+        await this.client.unlinkResource(formWithoutURIvariables);
         this.active = false;
     }
 

packages/core/src/exposed-thing.ts

@@ -595,7 +595,9 @@ export default class ExposedThing extends TD.Thing implements WoT.ExposedThing {
             }
             const unsubscribe = this.#eventHandlers.get(name)?.unsubscribe;
             if (unsubscribe) {
-                unsubscribe(options);
+                unsubscribe(options).catch((error) => {
+                    throw error;
+                });
             }
             debug(`ExposedThing '${this.title}' unsubscribes from event '${name}'`);
         } else {
@@ -663,7 +665,9 @@ export default class ExposedThing extends TD.Thing implements WoT.ExposedThing {
 
             const unobserveHandler = this.#propertyHandlers.get(name)?.unobserveHandler;
             if (unobserveHandler) {
-                unobserveHandler(options);
+                unobserveHandler(options).catch((error) => {
+                    throw error;
+                });
             }
         } else {
             throw new Error(`ExposedThing '${this.title}', no property found for '${name}'`);

packages/core/src/protocol-helpers.ts

@@ -215,17 +215,27 @@ export default class ProtocolHelpers {
         const reader = stream.getReader();
         const result = new ManagedReadable({
             read: (size) => {
-                reader.read().then((data) => {
-                    result.push(data.value);
-                    if (data.done) {
-                        // signal end
-                        result.push(null);
-                    }
-                });
+                reader
+                    .read()
+                    .then((data) => {
+                        result.push(data.value);
+                        if (data.done) {
+                            // signal end
+                            result.push(null);
+                        }
+                    })
+                    .catch((error) => {
+                        throw error;
+                    });
             },
             destroy: (error, callback) => {
                 reader.releaseLock();
-                stream.cancel(error).then(() => callback(error));
+                stream
+                    .cancel(error)
+                    .then(() => callback(error))
+                    .catch((error) => {
+                        throw error;
+                    });
             },
         });
         result.wotStream = stream as ReadableStream;

packages/core/test/client-test.ts

@@ -358,9 +358,14 @@ class WoTClientTest {
         this.clientFactory = new TrapClientFactory();
         this.servient.addClientFactory(this.clientFactory);
         this.servient.addClientFactory(new TDClientFactory());
-        this.servient.start().then((myWoT) => {
-            this.WoT = myWoT;
-        });
+        this.servient
+            .start()
+            .then((myWoT) => {
+                this.WoT = myWoT;
+            })
+            .catch((error) => {
+                throw error;
+            });
         debug("started test suite");
     }
 
@@ -570,11 +575,17 @@ class WoTClientTest {
         expect(thing).to.have.property("title").that.equals("aThing");
         expect(thing).to.have.property("events").that.has.property("anEvent");
         return new Promise((resolve) => {
-            thing.subscribeEvent("anEvent", async (x) => {
-                const value = await x.value();
-                expect(value).to.equal("triggered");
-                resolve(true);
-            });
+            thing
+                .subscribeEvent("anEvent", async (x) => {
+                    const value = await x.value();
+                    expect(value).to.equal("triggered");
+                    resolve(true);
+                })
+                .catch((error) => {
+                    throw error;
+                });
+        }).catch((error) => {
+            throw error;
         });
     }
 
@@ -626,17 +637,25 @@ class WoTClientTest {
         expect(thing).to.have.property("title").that.equals("aThing");
         expect(thing).to.have.property("events").that.has.property("anEvent");
 
-        const subscription = await thing.subscribeEvent("anEvent", () => {
-            /** */
-        });
+        const subscription = await thing
+            .subscribeEvent("anEvent", () => {
+                /** */
+            })
+            .catch((error) => {
+                throw error;
+            });
         await subscription.stop();
 
         return new Promise((resolve) => {
-            thing.subscribeEvent("anEvent", async (x) => {
-                const value = await x.value();
-                expect(value).to.equal("triggered");
-                resolve(true);
-            });
+            thing
+                .subscribeEvent("anEvent", async (x) => {
+                    const value = await x.value();
+                    expect(value).to.equal("triggered");
+                    resolve(true);
+                })
+                .catch((error) => {
+                    throw error;
+                });
         });
     }
 
@@ -649,11 +668,15 @@ class WoTClientTest {
         expect(thing).to.have.property("title").that.equals("aThing");
         expect(thing).to.have.property("properties").that.has.property("aPropertyToObserve");
         return new Promise((resolve) => {
-            thing.observeProperty("aPropertyToObserve", async (data) => {
-                const value = await data.value();
-                expect(value).to.equal(12);
-                resolve(true);
-            });
+            thing
+                .observeProperty("aPropertyToObserve", async (data) => {
+                    const value = await data.value();
+                    expect(value).to.equal(12);
+                    resolve(true);
+                })
+                .catch((error) => {
+                    throw error;
+                });
         });
     }
 

packages/core/test/server-test.ts

@@ -68,9 +68,14 @@ class WoTServerTest {
         this.servient = new Servient();
         this.server = new TestProtocolServer();
         this.servient.addServer(this.server);
-        this.servient.start().then((WoTruntime) => {
-            this.WoT = WoTruntime;
-        });
+        this.servient
+            .start()
+            .then((WoTruntime) => {
+                this.WoT = WoTruntime;
+            })
+            .catch((error) => {
+                throw error;
+            });
         debug("started test suite");
     }
 
@@ -889,7 +894,9 @@ class WoTServerTest {
 
         thing.setPropertyReadHandler("test", callback);
 
-        (thing as ExposedThing).handleObserveProperty("test", protocolListener, { formIndex: 0 });
+        (thing as ExposedThing).handleObserveProperty("test", protocolListener, { formIndex: 0 }).catch((error) => {
+            throw error;
+        });
 
         await (<ExposedThing>thing).emitPropertyChange("test");
 
@@ -964,7 +971,9 @@ class WoTServerTest {
         thing.setEventSubscribeHandler("test", handler);
         await (<ExposedThing>thing).handleSubscribeEvent("test", callback, { formIndex: 0 });
         (<ExposedThing>thing).emitEvent("test", null);
-        (<ExposedThing>thing).handleUnsubscribeEvent("test", callback, { formIndex: 0 });
+        (<ExposedThing>thing).handleUnsubscribeEvent("test", callback, { formIndex: 0 }).catch((error) => {
+            throw error;
+        });
         (<ExposedThing>thing).emitEvent("test", null);
 
         return expect(callback).to.have.been.called.once;