Skip to content

Handle long streams as inputs in HTTP binding #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
relu91 merged 4 commits into from
Apr 16, 2025
Merged

Handle long streams as inputs in HTTP binding #1369

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f014180
chore(binding-http): update node-fetch to lastest cjs version
relu91 Apr 12, 2025
cc5352c
fix(binding-http): handle long streams as inputs for affordances
relu91 Apr 12, 2025
9c2c425
fix(binding-http): fix browser client to handle stream based requests
relu91 Apr 14, 2025
4ef545c
refactor(binding-http): rename HttpClientImpl.fetch to doFetch
relu91 Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 39 additions & 43 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/binding-http/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"client-oauth2": "^4.2.5",
"eventsource": "^2.0.2",
"find-my-way": "^8.2.2",
"node-fetch": "^2.6.7",
"node-fetch": "^2.7.0",
"query-string": "^7.1.1",
"rxjs": "5.5.11",
"slugify": "^1.4.5"
Expand Down
8 changes: 6 additions & 2 deletions packages/binding-http/src/http-client-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,12 @@ export default class HttpClient implements ProtocolClient {
return request;
}

private async fetch(request: Request, content?: Content) {
const result = await fetch(request, { body: content?.body });
private async fetch(request: Request) {
// TODO: need investigation. Even if the request has already a body
// if we don't pass it again to the fetch as request init the stream is
// not correctly consumed
// see https://github.com/eclipse-thingweb/node-wot/issues/1366.
const result = await fetch(request, { body: request.body });

if (HttpClient.isOAuthTokenExpired(result, this.credential)) {
this.credential = await (this.credential as OAuthCredential).refreshToken();
Expand Down
Loading