Skip to content

chore : Added TypeScript types as dependencies instead of devDependencies#1478

Merged
relu91 merged 1 commit into
eclipse-thingweb:masterfrom
ViRUS-0-0:issue-1476
Feb 11, 2026
Merged

chore : Added TypeScript types as dependencies instead of devDependencies#1478
relu91 merged 1 commit into
eclipse-thingweb:masterfrom
ViRUS-0-0:issue-1476

Conversation

@ViRUS-0-0
Copy link
Copy Markdown
Contributor

Closes #1476

Summary

Moves @types/debug and @types/node-fetch from devDependencies to dependencies in packages/core and packages/binding-http.

Problem

The packages @node-wot/core and @node-wot/binding-http export types from debug and node-fetch in their public API (declaration files). However, these type definitions were listed in devDependencies, causing TypeScript compilation errors for consumers who do not have these types installed manually.

Solution

Moved the following packages to dependencies:

  • @types/debug in @node-wot/core
  • @types/node-fetch in @node-wot/binding-http

…o dependencies.

Signed-off-by: ViRUS-0-0 <mrvanwariomg@gmail.com>
@ViRUS-0-0 ViRUS-0-0 changed the title Added TypeScript types as dependencies instead of devDependencies chore : Added TypeScript types as dependencies instead of devDependencies Feb 10, 2026
Copy link
Copy Markdown
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@relu91 relu91 merged commit fcaa652 into eclipse-thingweb:master Feb 11, 2026
14 checks passed
@danielpeintner
Copy link
Copy Markdown
Member

I know I am late, but I think those changes in package.json should have been reflected in package-lock.json also (there it is still a devDependencies)

"@types/node-fetch": "^2.6.12",

Maybe we need to recreate the package-lock.json ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: Add TypeScript types as dependencies instead of devDependencies

4 participants