Writeable property callback was incorrect (#300)

* incorrect property callback

* add extra compiler warnings

Author: ryanwinter

NXP/MIMXRT1060-EVK/app/nx_client.c

@@ -100,13 +100,13 @@ static void set_led_state(bool level)
 {
     if (level)
     {
-        printf("LED is turned ON\r\n");
+        printf("\tLED is turned ON\r\n");
         // The User LED on the board shares the same pin as ENET RST (ethernet IC reset) so is unusable
         // USER_LED_ON();
     }
     else
     {
-        printf("LED is turned OFF\r\n");
+        printf("\tLED is turned OFF\r\n");
         // The User LED on the board shares the same pin as ENET RST (ethernet IC reset) so is unusable
         // USER_LED_OFF();
     }

STMicroelectronics/STM32L4_L4+/app/nx_client.c

@@ -271,8 +271,7 @@ UINT azure_iot_nx_client_entry(
         tx_event_flags_get(
             &azure_iot_flags, TELEMETRY_INTERVAL_EVENT, TX_OR_CLEAR, &events, telemetry_interval * NX_IP_PERIODIC_RATE);
 
-        azure_iot_nx_client_publish_telemetry(
-            &azure_iot_nx_client, NULL, append_device_telemetry);
+        azure_iot_nx_client_publish_telemetry(&azure_iot_nx_client, NULL, append_device_telemetry);
     }
 
     return NX_SUCCESS;

cmake/arm-gcc-cortex-toolchain.cmake

@@ -48,7 +48,7 @@ set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY)
 set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY)
 set(CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY)
 
-set(CMAKE_COMMON_FLAGS "-g3 --specs=nano.specs -ffunction-sections -fdata-sections -fno-strict-aliasing -fno-builtin -fshort-enums -Wall -Wextra -Wuninitialized -Wshadow -Wdouble-promotion -Werror -Wno-unused-parameter")
+set(CMAKE_COMMON_FLAGS "-g3 --specs=nano.specs -ffunction-sections -fdata-sections -fno-strict-aliasing -fno-builtin -fshort-enums -Wall -Wextra -Wuninitialized -Wmaybe-uninitialized -Wshadow -Wdouble-promotion -Werror -Wno-unused-parameter")
 set(CMAKE_C_FLAGS 	"${MCPU_FLAGS} ${VFP_FLAGS} ${CMAKE_COMMON_FLAGS}")
 set(CMAKE_CXX_FLAGS "${MCPU_FLAGS} ${VFP_FLAGS} ${CMAKE_COMMON_FLAGS}")
 set(CMAKE_ASM_FLAGS "${MCPU_FLAGS} ${VFP_FLAGS}")

shared/src/azure_iot_nx_client.c

@@ -298,7 +298,7 @@ static VOID process_writable_properties(AZURE_IOT_NX_CONTEXT* nx_context)
 
     printf_packet("Receive properties: ", packet_ptr);
 
-    if (nx_context->property_received_cb)
+    if (nx_context->writable_property_received_cb)
     {
         // Parse the writable properties from the writable receive message
         if ((status = process_properties_shared(nx_context,
@@ -307,7 +307,7 @@ static VOID process_writable_properties(AZURE_IOT_NX_CONTEXT* nx_context)
                  NX_AZURE_IOT_HUB_CLIENT_PROPERTY_WRITABLE,
                  properties_buffer,
                  sizeof(properties_buffer),
-                 nx_context->property_received_cb)))
+                 nx_context->writable_property_received_cb)))
         {
             printf("Error: failed to parse properties (0x%08x)\r\n", status);
         }