tmf: extend api for configuration 5

Author: frallax

analyses/org.eclipse.tracecompass.incubator.inandout.core/src/org/eclipse/tracecompass/incubator/internal/inandout/core/analysis/InAndOutDataProviderFactory.java

@@ -151,8 +151,7 @@ protected void applyConfiguration(ITmfTrace trace, ITmfConfiguration config, boo
         try {
             create(config, trace, writeConfig, new InAndOutAnalysisModule());
         } catch (TmfConfigurationException e) {
-            // TODO Auto-generated catch block
-            e.printStackTrace();
+            Activator.getInstance().logError(e.getMessage(), e);
         }
     }
 
@@ -168,8 +167,7 @@ protected void removeConfiguration(ITmfTrace trace, ITmfConfiguration config) {
         try {
             remove(config, trace, InAndOutAnalysisModule.ID);
         } catch (TmfConfigurationException e) {
-            // TODO Auto-generated catch block
-            e.printStackTrace();
+            Activator.getInstance().logError(e.getMessage(), e);
         }
     }
 
@@ -185,7 +183,6 @@ protected void removeConfiguration(ITmfTrace trace, ITmfConfiguration config) {
      * @throws TmfConfigurationException if an error occurs
      */
     private void remove(ITmfConfiguration config, @NonNull ITmfTrace trace, String baseAnalysisId) throws TmfConfigurationException {
-        // IPath traceConfig = getConfigurationRootFolder(trace, config.getSourceTypeId());
         IPath traceConfig = getConfigurationRootFolder(trace);
         traceConfig = traceConfig.append(File.separator).append(config.getId()).addFileExtension(JSON_EXTENSION);
         File configFile = traceConfig.toFile();
@@ -224,7 +221,6 @@ public void create(@NonNull ITmfConfiguration config, @NonNull ITmfTrace trace,
          */
         module.setConfiguration(config);
         if (writeConfig) {
-            // IPath traceConfigPath = getConfigurationRootFolder(trace, config.getSourceTypeId());
             IPath traceConfigPath = getConfigurationRootFolder(trace);
             writeConfiguration(config, traceConfigPath);
         }
@@ -245,13 +241,6 @@ public void create(@NonNull ITmfConfiguration config, @NonNull ITmfTrace trace,
         }
     }
 
-//    protected IPath getConfigurationRootFolder(ITmfTrace trace, String subFolder) {
-//        String supplFolder = TmfTraceManager.getSupplementaryFileDir(trace);
-//        IPath supplPath = new Path(supplFolder);
-//        supplPath = supplPath.addTrailingSeparator().append(subFolder);
-//        return supplPath;
-//    }
-
     @Override
     protected IPath getConfigurationRootFolder(ITmfTrace trace) {
         String supplFolder = TmfTraceManager.getSupplementaryFileDir(trace);