Skip to content

releng: Upgrade target to dependencies of 2026-03 (Eclipse 4.39) release#267

Merged
arfio merged 2 commits into
eclipse-tracecompass-incubator:masterfrom
arfio:releng
Apr 13, 2026
Merged

releng: Upgrade target to dependencies of 2026-03 (Eclipse 4.39) release#267
arfio merged 2 commits into
eclipse-tracecompass-incubator:masterfrom
arfio:releng

Conversation

@arfio
Copy link
Copy Markdown
Contributor

@arfio arfio commented Apr 13, 2026

What it does

filters.core: Fix issue to make the build work
releng: Upgrade target to dependencies of 2026-03 (Eclipse 4.39) release

How to test

Set up Trace Compass with Incubator plugins, compile and run.

Follow-ups

N/A

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

Summary by CodeRabbit

  • Chores
    • Updated build platform dependencies to latest stable versions
    • Removed unused SSL-related connectivity features from product distribution
    • Corrected documentation text in language filter client

arfio added 2 commits April 13, 2026 11:18
Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
@arfio arfio changed the title Releng releng: Upgrade target to dependencies of 2026-03 (Eclipse 4.39) release Apr 13, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 13, 2026

📝 Walkthrough

Walkthrough

Javadoc corrections and grammar fixes in the language filter client; constructor signature simplification for content change events; target platform repository URLs updated to latest release versions; and SSL-related features removed from the product configuration.

Changes

Cohort / File(s) Summary
Language Filter Client Updates
analyses/org.eclipse.tracecompass.incubator.filters.core/src/org/eclipse/tracecompass/incubator/internal/filters/core/client/LanguageFilterClient.java
Fixed Javadoc wording (grammar and spelling corrections). Modified TextDocumentContentChangeEvent constructor call in tellDidChange method by removing the explicit max + 1 length argument, simplifying the event creation signature.
Target Platform Dependency Updates
common/org.eclipse.tracecompass.incubator.target/tracecompass-incubator-master.target
Updated provisioning repository URLs to newer release versions: JustJ JRE (21.0.9→21.0.10), CDT (12.3.0→12.4.0), Orbit (4.38.0→4.39.0), Eclipse platform (4.38→4.39), WebTools, EMF (2.44.0→2.45.0), ECF (3.15.5→3.16.2), LSP4J (0.24.0→1.0.0), and Xtext/TMF (2.40.0→2.42.0).
Product Feature Configuration
rcp/org.eclipse.tracecompass.incubator.rcp.product/tracing.incubator.product
Removed two ECF SSL-related features from the product's feature list: org.eclipse.ecf.core.ssl.feature and org.eclipse.ecf.filetransfer.ssl.feature.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 The code hops forward with spelling renewed,
Constructor calls simplified, cleaner and true!
Dependencies fresh, from the repositories in view,
SSL features pruned for a lighter debut—
All changes precise, not a whisker askew! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: upgrading target dependencies to Eclipse 4.39 (2026-03 release), which is the primary focus of the changeset with multiple dependency version updates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
analyses/org.eclipse.tracecompass.incubator.filters.core/src/org/eclipse/tracecompass/incubator/internal/filters/core/client/LanguageFilterClient.java (1)

210-214: ⚠️ Potential issue | 🟠 Major

Fix off-by-one error in Range for full text replacement.

At lines 210-212, the Range end position is incorrectly set to input.length() - 1. LSP ranges are end-exclusive, so the end position should be input.length() to correctly span the entire input. This inconsistency is evident in FilterBoxService.java (lines 108-112), which properly uses Position(0, input.length()) for the same operation.

Proposed fix
-        Integer min = 0;
-        Integer max = input.length() - 1;
-        Position p1 = new Position(0, min);
-        Position p2 = new Position(0, max);
+        Position p1 = new Position(0, 0);
+        Position p2 = new Position(0, input.length());
         Range r = new Range(p1, p2);
         TextDocumentContentChangeEvent change = new TextDocumentContentChangeEvent(r, input);
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@analyses/org.eclipse.tracecompass.incubator.filters.core/src/org/eclipse/tracecompass/incubator/internal/filters/core/client/LanguageFilterClient.java`
around lines 210 - 214, The Range used for creating the
TextDocumentContentChangeEvent is off-by-one: change the end column calculation
so the end Position uses input.length() (end-exclusive) instead of
input.length() - 1; update the code constructing Position p2 (and the variable
max if present) used by new Range(p1, p2) so the Range spans the full input when
creating the TextDocumentContentChangeEvent in LanguageFilterClient.java
(symbols: Position, Range, TextDocumentContentChangeEvent, input, min, max).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@common/org.eclipse.tracecompass.incubator.target/tracecompass-incubator-master.target`:
- Line 6: The target file contains a broken p2 repository URL (<repository
location="https://download.eclipse.org/rt/ecf/3.16.2/site.p2/">) which returns
404 and blocks target resolution; update each occurrence of that repository URL
(the <repository location="https://download.eclipse.org/rt/ecf/3.16.2/site.p2/">
entries referenced in the diff and the other affected occurrences) to a valid
ECF p2 URL or an available ECF release (e.g., change 3.16.2 to a known-good
version) or remove the repository entry if not required, then re-run target
resolution to confirm the build succeeds.

---

Outside diff comments:
In
`@analyses/org.eclipse.tracecompass.incubator.filters.core/src/org/eclipse/tracecompass/incubator/internal/filters/core/client/LanguageFilterClient.java`:
- Around line 210-214: The Range used for creating the
TextDocumentContentChangeEvent is off-by-one: change the end column calculation
so the end Position uses input.length() (end-exclusive) instead of
input.length() - 1; update the code constructing Position p2 (and the variable
max if present) used by new Range(p1, p2) so the Range spans the full input when
creating the TextDocumentContentChangeEvent in LanguageFilterClient.java
(symbols: Position, Range, TextDocumentContentChangeEvent, input, min, max).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e6cc500a-a202-4854-b56d-85e427091c62

📥 Commits

Reviewing files that changed from the base of the PR and between de7e96d and 944b31a.

📒 Files selected for processing (3)
  • analyses/org.eclipse.tracecompass.incubator.filters.core/src/org/eclipse/tracecompass/incubator/internal/filters/core/client/LanguageFilterClient.java
  • common/org.eclipse.tracecompass.incubator.target/tracecompass-incubator-master.target
  • rcp/org.eclipse.tracecompass.incubator.rcp.product/tracing.incubator.product
💤 Files with no reviewable changes (1)
  • rcp/org.eclipse.tracecompass.incubator.rcp.product/tracing.incubator.product

@arfio arfio merged commit 2fdf319 into eclipse-tracecompass-incubator:master Apr 13, 2026
3 checks passed
@arfio arfio deleted the releng branch April 13, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants