releng: Upgrade target to dependencies of 2026-03 (Eclipse 4.39) release#267
Conversation
Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
📝 WalkthroughWalkthroughJavadoc corrections and grammar fixes in the language filter client; constructor signature simplification for content change events; target platform repository URLs updated to latest release versions; and SSL-related features removed from the product configuration. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
analyses/org.eclipse.tracecompass.incubator.filters.core/src/org/eclipse/tracecompass/incubator/internal/filters/core/client/LanguageFilterClient.java (1)
210-214:⚠️ Potential issue | 🟠 MajorFix off-by-one error in Range for full text replacement.
At lines 210-212, the Range end position is incorrectly set to
input.length() - 1. LSP ranges are end-exclusive, so the end position should beinput.length()to correctly span the entire input. This inconsistency is evident in FilterBoxService.java (lines 108-112), which properly usesPosition(0, input.length())for the same operation.Proposed fix
- Integer min = 0; - Integer max = input.length() - 1; - Position p1 = new Position(0, min); - Position p2 = new Position(0, max); + Position p1 = new Position(0, 0); + Position p2 = new Position(0, input.length()); Range r = new Range(p1, p2); TextDocumentContentChangeEvent change = new TextDocumentContentChangeEvent(r, input);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@analyses/org.eclipse.tracecompass.incubator.filters.core/src/org/eclipse/tracecompass/incubator/internal/filters/core/client/LanguageFilterClient.java` around lines 210 - 214, The Range used for creating the TextDocumentContentChangeEvent is off-by-one: change the end column calculation so the end Position uses input.length() (end-exclusive) instead of input.length() - 1; update the code constructing Position p2 (and the variable max if present) used by new Range(p1, p2) so the Range spans the full input when creating the TextDocumentContentChangeEvent in LanguageFilterClient.java (symbols: Position, Range, TextDocumentContentChangeEvent, input, min, max).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@common/org.eclipse.tracecompass.incubator.target/tracecompass-incubator-master.target`:
- Line 6: The target file contains a broken p2 repository URL (<repository
location="https://download.eclipse.org/rt/ecf/3.16.2/site.p2/">) which returns
404 and blocks target resolution; update each occurrence of that repository URL
(the <repository location="https://download.eclipse.org/rt/ecf/3.16.2/site.p2/">
entries referenced in the diff and the other affected occurrences) to a valid
ECF p2 URL or an available ECF release (e.g., change 3.16.2 to a known-good
version) or remove the repository entry if not required, then re-run target
resolution to confirm the build succeeds.
---
Outside diff comments:
In
`@analyses/org.eclipse.tracecompass.incubator.filters.core/src/org/eclipse/tracecompass/incubator/internal/filters/core/client/LanguageFilterClient.java`:
- Around line 210-214: The Range used for creating the
TextDocumentContentChangeEvent is off-by-one: change the end column calculation
so the end Position uses input.length() (end-exclusive) instead of
input.length() - 1; update the code constructing Position p2 (and the variable
max if present) used by new Range(p1, p2) so the Range spans the full input when
creating the TextDocumentContentChangeEvent in LanguageFilterClient.java
(symbols: Position, Range, TextDocumentContentChangeEvent, input, min, max).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e6cc500a-a202-4854-b56d-85e427091c62
📒 Files selected for processing (3)
analyses/org.eclipse.tracecompass.incubator.filters.core/src/org/eclipse/tracecompass/incubator/internal/filters/core/client/LanguageFilterClient.javacommon/org.eclipse.tracecompass.incubator.target/tracecompass-incubator-master.targetrcp/org.eclipse.tracecompass.incubator.rcp.product/tracing.incubator.product
💤 Files with no reviewable changes (1)
- rcp/org.eclipse.tracecompass.incubator.rcp.product/tracing.incubator.product
What it does
filters.core: Fix issue to make the build work
releng: Upgrade target to dependencies of 2026-03 (Eclipse 4.39) release
How to test
Set up Trace Compass with Incubator plugins, compile and run.
Follow-ups
N/A
Review checklist
Summary by CodeRabbit