analysis.graph: Cleanup non-API deprecation issues in dependency graph

Fixes issue #87

[Removed] CriticalPathModule
[Removed] CriticalPathPalette

Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>

Author: PatrickTasse

analysis/org.eclipse.tracecompass.analysis.graph.core/src/org/eclipse/tracecompass/analysis/graph/core/criticalpath/AbstractCriticalPathModule.java

@@ -25,9 +25,9 @@
 import org.eclipse.tracecompass.analysis.graph.core.graph.WorkerSerializer;
 import org.eclipse.tracecompass.common.core.NonNullUtils;
 import org.eclipse.tracecompass.internal.analysis.graph.core.Activator;
-import org.eclipse.tracecompass.internal.analysis.graph.core.criticalpath.CriticalPathModule;
 import org.eclipse.tracecompass.internal.analysis.graph.core.criticalpath.Messages;
 import org.eclipse.tracecompass.internal.analysis.graph.core.criticalpath.OSCriticalPathAlgorithm;
+import org.eclipse.tracecompass.tmf.core.analysis.TmfAbstractAnalysisModule;
 import org.eclipse.tracecompass.tmf.core.exceptions.TmfAnalysisException;
 import org.eclipse.tracecompass.tmf.core.trace.ITmfTrace;
 import org.eclipse.tracecompass.tmf.core.trace.TmfTraceManager;
@@ -41,7 +41,13 @@
  * @author Geneviève Bastien
  * @since 4.0
  */
-public abstract class AbstractCriticalPathModule extends CriticalPathModule {
+public abstract class AbstractCriticalPathModule extends TmfAbstractAnalysisModule implements ICriticalPathProvider {
+
+    /**
+     * Analysis ID for this module
+     * @since 5.0
+     */
+    public static final String ANALYSIS_ID = "org.eclipse.tracecompass.analysis.graph.core.criticalpath"; //$NON-NLS-1$
 
     /** Worker_id parameter name */
     public static final String PARAM_WORKER = "workerid"; //$NON-NLS-1$
@@ -62,7 +68,6 @@ public abstract class AbstractCriticalPathModule extends CriticalPathModule {
      * @since 1.1
      */
     public AbstractCriticalPathModule(AbstractTmfGraphBuilderModule graph) {
-        super(graph);
         addParameter(PARAM_WORKER);
         setId(ANALYSIS_ID);
         fGraphModule = graph;

analysis/org.eclipse.tracecompass.analysis.graph.core/src/org/eclipse/tracecompass/internal/analysis/graph/core/base/CriticalPathPalette.java

@@ -32,7 +32,6 @@
 import org.eclipse.tracecompass.analysis.graph.core.graph.ITmfGraph;
 import org.eclipse.tracecompass.analysis.graph.core.graph.ITmfGraphVisitor;
 import org.eclipse.tracecompass.analysis.graph.core.graph.ITmfVertex;
-import org.eclipse.tracecompass.analysis.graph.core.graph.TmfGraphFactory;
 import org.eclipse.tracecompass.common.core.NonNullUtils;
 import org.eclipse.tracecompass.internal.analysis.graph.core.base.TmfEdge.EdgeType;
 import org.eclipse.tracecompass.internal.analysis.graph.core.base.TmfVertex.EdgeDirection;
@@ -55,10 +54,7 @@
  *
  * @author Francis Giraldeau
  * @author Geneviève Bastien
- * @deprecated Use the {@link ITmfGraph} API instead, and the
- *             {@link TmfGraphFactory} to create new graphs.
  */
-@Deprecated
 public class TmfGraph {
 
     private final ListMultimap<IGraphWorker, TmfVertex> fNodeMap;

analysis/org.eclipse.tracecompass.analysis.graph.core/src/org/eclipse/tracecompass/internal/analysis/graph/core/base/TmfGraph.java

@@ -1,5 +1,5 @@
 /**********************************************************************
- * Copyright (c) 2018, 2022 Ericsson
+ * Copyright (c) 2018, 2024 Ericsson
  *
  * All rights reserved. This program and the accompanying materials are
  * made available under the terms of the Eclipse Public License 2.0 which
@@ -151,7 +151,7 @@ public CriticalPathDataProvider(@NonNull ITmfTrace trace, @NonNull AbstractCriti
     }
 
     /**
-     * Get the current {@link IGraphWorker} from the {@link CriticalPathModule}
+     * Get the current {@link IGraphWorker} from the critical path module
      *
      * @return the current graph worker if it is set, else null.
      */

analysis/org.eclipse.tracecompass.analysis.graph.core/src/org/eclipse/tracecompass/internal/analysis/graph/core/criticalpath/CriticalPathModule.java

@@ -35,7 +35,6 @@
  *
  * @author Geneviève Bastien
  */
-@SuppressWarnings("deprecation")
 public class TmfGraphLegacyWrapper implements ITmfGraph {
 
     /* Latch tracking if the graph is done building or not */