xml: Add data provider/descriptor list methods to XmlDataProviderManager#247
Merged
Merged
Conversation
PatrickTasse
approved these changes
Apr 8, 2025
PatrickTasse
requested changes
Apr 8, 2025
| * the trace, else null | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| public <@Nullable P extends ITmfTreeDataProvider<? extends ITmfTreeDataModel>> P getXmlProvider(ITmfTrace trace, String id, Set<OutputType> types) { |
Contributor
PatrickTasse
previously approved these changes
Apr 9, 2025
| * the trace, else null | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| @Nullable public <P extends ITmfTreeDataProvider<? extends ITmfTreeDataModel>> P getXmlProvider(ITmfTrace trace, String id, Set<OutputType> types) { |
Contributor
There was a problem hiding this comment.
Consider changing to public @Nullable
bhufmann
force-pushed
the
xml-dp-manager
branch
2 times, most recently
from
4431667 to
12fd2cd
Compare
These methods are migrated from the trace server's DataProviderService. [Added] data provider/descriptor list methods to XmlDataProviderManager Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
force-pushed
the
xml-dp-manager
branch
from
12fd2cd to
54967e7
Compare
PatrickTasse
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
These methods are migrated from the trace server's DataProviderService.
[Added] data provider/descriptor list methods to XmlDataProviderManager
How to test
Replace methods in trace-server's DataProviderService with this new API and verify that XML analysis DPs are available as before.
Follow-ups
Review checklist