Mark name attributes for org.eclipse.linuxtools.tmf.core extension point as translatable#295
Merged
bhufmann merged 1 commit intoAug 21, 2025
Conversation
Names of * category * type * experiment are user-visible string and should have corresponding metadata to help PDE control its values.
ruspl-afed
changed the title
name attributes as translatablename attributes for org.eclipse.linuxtools.tmf.core extension point as translatable
bhufmann
approved these changes
Jul 22, 2025
bhufmann
left a comment
bhufmann
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thanks for the contribution!
Contributor
Author
|
Thank you for review @bhufmann ! |
Contributor
Great to hear. BTW, the project requires 2 approvals for non-committer contributions. That's why I haven't merged. Looking forward to the contributions. Thanks! |
bhufmann
requested review from
PatrickTasse
and removed request for
MatthewKhouzam
PatrickTasse
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names of
are user-visible string and should have corresponding metadata to help PDE control its values.
What it does
PDE doesn't trigger on non-externalized name attribute.
This PR adds "translatable" metadata for
nameattribute to the extension point schemaHow to test
After applying this change (and restarting IDE) PDE should recognize mentioned attributes as translatable
(use "Plug-in Tools -> Externalize String" from the project context menu)
Follow-ups
I would say that this PR introduces technical debt, it is rather will help to resolve existing one with not translated names.
Review checklist