timing: Return FAILED when analysis failed in SegmentStoreStatisticsDp #312
Merged
Merged
Conversation
bhufmann
force-pushed
the
fixSegmentStoredp
branch
from
1805880 to
4faeb22
Compare
PatrickTasse
requested changes
Sep 2, 2025
| } | ||
| } | ||
|
|
||
| if (!success && module.getFailureCause() != null) { |
Contributor
There was a problem hiding this comment.
What should we do in case of failure but the failure cause is null?
Contributor
Author
There was a problem hiding this comment.
This would be not detected because waitForCompletion returns a single boolean. We only can detect failure if failure cause is not null. So, I guess it's mandatory with the current implementation.
| if (monitor != null) { | ||
| module.waitForCompletion(monitor); | ||
| success = module.waitForCompletion(monitor); | ||
| if (monitor.isCanceled()) { |
Contributor
There was a problem hiding this comment.
If there is failure but also monitor canceled, should the failure override the cancel? i.e. should we return cancelled only if there is no failure cause?
Contributor
Author
There was a problem hiding this comment.
Mmh, good question. I'll check. Probably failure has priority.
Fixes eclipse-tracecompass#302 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
force-pushed
the
fixSegmentStoredp
branch
from
4faeb22 to
fa9d79d
Compare
PatrickTasse
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
timing: Return FAILED when analysis failed in SegmentStoreStatisticsDp
Fixes #302
How to test
Verify with added JUnit test case (
SegmentStoreStatisticsDataProviderTest#testModuleExecutionError)Follow-ups
N/A
Review checklist