linux.core: : Add IRQ handlers instead of generic IRQs#314
Merged
Conversation
arfio
requested changes
Sep 22, 2025
arfio
left a comment
arfio
left a comment
Contributor
There was a problem hiding this comment.
I like this patch a lot, it makes IRQ much easier to understand! (I just want a small number of formatting changes so that it looks good)
| List<Integer> subAttrs = ss.getSubAttributes(KernelEventHandlerUtils.getNodeIRQs(cpu, ss),false); | ||
| String irqPrefix = irqId.toString()+"/"; //$NON-NLS-1$ | ||
| List<Integer> quarks = subAttrs.stream().filter(iquark -> ss.getAttributeName(iquark).startsWith(irqPrefix)).toList(); | ||
| int quark =-1; |
Contributor
There was a problem hiding this comment.
-1 is a magical number, it would be better if replaced by ITmfStateSystem.ROOT_ATTRIBUTE
| * CPU on which this IRQ is sitting | ||
| */ | ||
| int quark = ss.getQuarkRelativeAndAdd(KernelEventHandlerUtils.getNodeIRQs(cpu, ss), irqId.toString()); | ||
| int quark = ss.getQuarkRelativeAndAdd(KernelEventHandlerUtils.getNodeIRQs(cpu, ss), irqId.toString()+"/"+name); |
Contributor
There was a problem hiding this comment.
space + non-externalized string
|
|
||
| /* Update the aggregate IRQ entry to set it to this CPU */ | ||
| int aggregateQuark = ss.getQuarkAbsoluteAndAdd(Attributes.IRQS, irqId.toString()); | ||
| int aggregateQuark = ss.getQuarkAbsoluteAndAdd(Attributes.IRQS, irqId.toString()+"/"+name); |
| } | ||
| int currentThreadNode = KernelEventHandlerUtils.getCurrentThreadNode(cpu, ss); | ||
| Integer irqId = ((Long) event.getContent().getField(getLayout().fieldIrq()).getValue()).intValue(); | ||
| List<Integer> subAttrs = ss.getSubAttributes(KernelEventHandlerUtils.getNodeIRQs(cpu, ss),false); |
MatthewKhouzam
force-pushed
the
irq_handler
branch
from
930247c to
b79e7fb
Compare
arfio
previously approved these changes
Oct 23, 2025
Currently, the Resources view only shows IRQs as a single entity. This makes it harder to distinguish which handler is actually running, especially in cases where multiple IRQ handlers are mapped to the same lane. This change updates the view to display IRQ handlers instead of just the IRQ, providing finer granularity and improving readability when a single lane contains multiple handlers. Benefits: * Clearer visualization of interrupt activity. * Easier to identify which handler is active at a given time. * Better distinction when multiple handlers share one IRQ lane. [Added] Add handlers to IRQs in resources views Change-Id: I131790ec6dad3b28328abea0c5d84b280a7b196e Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
MatthewKhouzam
force-pushed
the
irq_handler
branch
from
b79e7fb to
3633bbb
Compare
arfio
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Resources view only shows IRQs as a single entity. This makes it harder to distinguish which handler is actually running, especially in cases where multiple IRQ handlers are mapped to the same lane.
Benefits:
What it does
This change updates the view to display IRQ handlers instead of just the IRQ, providing finer granularity and improving readability when a single lane contains multiple handlers.
How to test
Open a Kernel Trace. The LibXZ ones have two irq21s.
Follow-ups
Deprecate IRQ analysis. Keep density charts though.
Review checklist