tmf.ui.swtbot.tests: Modify button name to make the test work

[arfio]

What it does

tmf.ui.swtbot.tests: Modify button name to make the test work with the interface change

How to test

Run the tests

Follow-ups

N/A

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

Summary by CodeRabbit

• Tests
  • Updated test dialog interactions to align with current UI button labeling.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2dae25d1-f169-4c16-b9e5-9d89ec17f080

📥 Commits

Reviewing files that changed from the base of the PR and between 1c6b215 and 664b774.

📒 Files selected for processing (1)

• tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/src/org/eclipse/tracecompass/tmf/ui/swtbot/tests/project/AddProjectNatureTest.java

---

📝 Walkthrough

Walkthrough

This PR updates SWTBot test UI dialog controls to use an APPLY button label instead of OK. The toggleFilters helper method now clicks the APPLY button to confirm filter dialogs through a new string constant.

Changes

Filter Dialog Button Update

Layer / File(s)	Summary
Apply button constant and usage tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/src/org/eclipse/tracecompass/tmf/ui/swtbot/tests/project/AddProjectNatureTest.java	New APPLY_BUTTON constant added at line 93, and the toggleFilters method updated at line 252 to click the APPLY button instead of OK when confirming filter dialogs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A button renamed, a path made straight,
From OK to APPLY, no more to wait,
In tests we hop and click with care,
Dialog dialogs answered fair! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: modifying a button name (from OK to APPLY) in tmf.ui.swtbot.tests to fix a test.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[MatthewKhouzam]

classic

[tuanvtdeptre199]

Hi @arfio, could you please help me check this commit again? I see that one of the build jobs has failed due to this commit, and unfortunately, it cause failed too in my commit.
Thank you in advance.

[arfio]

Hi @tuanvtdeptre199 The issue will be fixed in the next release of Trace Compass on June 10th, meanwhile all additions are paused. The issue comes from a test which fails with the new dependencies, to make the build pass for the release candidate, I had to change the test which temporarily makes the CI fail. When the release takes place next week on June 10th, the dependencies will be updated and the CI will be working again.

[tuanvtdeptre199]

@arfio, Thank you for sharing information. Then I will wait for the release and check this issue again.