Skip to content

[AsyncFileHandler] insure good synchronization for 'fRecordBuffer' #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhufmann merged 1 commit into from
Jun 5, 2025
Merged

[AsyncFileHandler] insure good synchronization for 'fRecordBuffer' #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/main/java/org/eclipse/tracecompass/traceeventlogger/AsyncFileHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
*/
public class AsyncFileHandler extends StreamHandler {
private static final LogRecord CLOSE_EVENT = new LogRecord(Level.FINEST, "CLOSE_EVENT"); //$NON-NLS-1$
private FileHandler fFileHandler;
private final FileHandler fFileHandler;
private BlockingQueue<List<LogRecord>> fQueue;
private Thread fWriterThread;
private int fMaxSize = 1024;
Expand All @@ -105,9 +105,7 @@ public class AsyncFileHandler extends StreamHandler {
TimerTask fTask = new TimerTask() {
@Override
public void run() {
if (!fRecordBuffer.isEmpty()) {
flush();
}
flush();
}
};

Expand Down Expand Up @@ -290,8 +288,10 @@ public synchronized void close() throws SecurityException {
@Override
public synchronized void flush() {
try {
fQueue.put(fRecordBuffer);
fRecordBuffer = new ArrayList<>(fMaxSize);
if (!fRecordBuffer.isEmpty()) {
fQueue.put(fRecordBuffer);
fRecordBuffer = new ArrayList<>(fMaxSize);
}
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
Expand Down