feat: first updated esds communication KIT.#1555
Conversation
- Introduced a new category for the eSDScom KIT in sidebarsDocsKits.js with links to its changelog and views. - Added the eSDScom KIT logo as an SVG file along with its licensing information. - Updated the generated kit navigation items to include the eSDScom KIT with its corresponding route.
matbmoser
left a comment
There was a problem hiding this comment.
So I have supported you on finding a logo and setting up the KIT structure correctly.
I did not changed any content from the KIT since this is something that I would expect you to do (Since you know more than me)
However I have provided some feedback as an external adopter, and also added some points which normally other KITs are also doing.
I feel that is missing some "valuable" content description here, like some JSON payloads for example. I see the model is not published so I would recommend you to add it here.
I know it is long, but it would bring value if it is at least organized in sections with each payload being available to be seen in JSON format.
You can use <details> tags to hide the payloads so it is easier to read if the files are too big. I have provided some examples how to do it. You can even include it inside code blocks from Markdown.
|
|
||
| ### Core Semantic Models | ||
|
|
||
| [io.catenax.esdscom 1.0.0 extended Safety Data Sheet communication](https://github.com/eclipse-tractusx/sldt-semantic-models/tree/main/io.catenax.esdscom/1.0.0) |
There was a problem hiding this comment.
This link does not exists! There is no published datamodel, and if it would be published this would not be the url.
There was a problem hiding this comment.
Since this model is not published feel free to add it here:
<details>
<summary><strong>Catena-X Safety Datasheet Model Payload</summary>
Add your model here:
...
</details>
| "leftOperand": "UsagePurpose", | ||
| "operator": "isAnyOf", | ||
| "rightOperand": [ | ||
| "cx.esdscom.base:1" |
There was a problem hiding this comment.
is this aligned with the Expert Group from data sovereignty? @DanielaWuensch
There was a problem hiding this comment.
Not sure if this is how we should reference.
There was a problem hiding this comment.
Was aligned with Daniela Wuensch.
Mail von Freitag, 10. April 2026:
"Hallo Dirk, hallo Anita,
Die Änderung in CX-0152 zum eSDScom purpose sind in diesem PR an dieser Stelle:
bereit für den Review. Darauf könnt ihr euch dann mit dem rightOperand cx.esdscom.base:1 des Usage Purpose beziehen.
Viele Grüße,
Daniela"
|
|
||
| ## Tutorials & Resources | ||
|
|
||
| Not yet available. |
There was a problem hiding this comment.
If you dont have tutorials just remove it.
| ### Model Example | ||
|
|
||
| Due to the model size, for further information please refer to [esdscom.eu](https://esdscom.eu) | ||
|
|
There was a problem hiding this comment.
We could add an example here if you would like, that would give some quality to the documentation.
feel free to add it like this, so it gets "hidden" in a dropdown:
<details>
<summary><strong>XML Safety Datasheet Model</summary>
Add your model here:
...
</details>
There was a problem hiding this comment.
@dirk-qualisys : Could you please add the draft model or the XML here?
|
@copilot please find typos |
|
Please review if the KIT logo is correct and you like it. Added a random color, since this is a different use case than "just sustainability". |
|
Policy is correct just confirmed with the DataSov EG. Not sure if we should use Neptune 2026/09/ in the context from json-ld. |
| "https://w3id.org/catenax/2025/9/policy/odrl.jsonld", | ||
| "https://w3id.org/catenax/2025/9/policy/context.jsonld" |
There was a problem hiding this comment.
This is where I meant. @jSchuetz88 is possible to use 2026 here?
|
@matbmoser : we try to eliminate the errors within the ticket but cannot edit. Can you please advice us, how to fork this repository, so that we can work in it? |
ok normally Andrew could edit its own branch in the fork |
|
I can apply at least the suggestions I have done. |
|
@Andrew96897 I have applied the edit to the points I have told. The only thing that is missing is to add the data models. @hillmer adding the data models is something that I cant do. I have requested the KIT master builder to do a check for typos and final quality checks. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| ### Changed | ||
|
|
||
| - Nothing yet | ||
|
|
||
| ### Deprecated | ||
|
|
||
| - Nothing yet | ||
|
|
||
| ### Removed | ||
|
|
||
| - Nothing yet | ||
|
|
||
| ### Fixed | ||
|
|
||
| - Nothing yet | ||
|
|
||
| ### Security | ||
|
|
||
| - Nothing yet |
| "leftOperand": "UsagePurpose", | ||
| "operator": "isAnyOf", | ||
| "rightOperand": [ | ||
| "cx.esdscom.base:1" |
|
|
||
| Model: eSDScom | ||
| Version: 1.0.0 | ||
| Namespace: urn:samm:io.catenax.eSDScom:1.0.0 |
| #### Standards | ||
|
|
||
| Technical standards and protocol compliance are not applicable. | ||
|
|
||
| #### Tutorials | ||
|
|
||
| Developer quick-start guides and code examples are not yet available. |
There was a problem hiding this comment.
| #### Standards | |
| Technical standards and protocol compliance are not applicable. | |
| #### Tutorials | |
| Developer quick-start guides and code examples are not yet available. |
I would take this out, because it does not adds value.
semantic model part updated
Description
[ADDED BY MATHIAS]
This is like the kit logo looks like:
From sideways:
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: