Skip to content

feat: first updated esds communication KIT.#1555

Open
Andrew96897 wants to merge 10 commits into
eclipse-tractusx:mainfrom
Andrew96897:eSDS
Open

feat: first updated esds communication KIT.#1555
Andrew96897 wants to merge 10 commits into
eclipse-tractusx:mainfrom
Andrew96897:eSDS

Conversation

@Andrew96897

@Andrew96897 Andrew96897 commented Jun 18, 2026

Copy link
Copy Markdown

Description

[ADDED BY MATHIAS]

This is like the kit logo looks like:

image

From sideways:

image

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

- Introduced a new category for the eSDScom KIT in sidebarsDocsKits.js with links to its changelog and views.
- Added the eSDScom KIT logo as an SVG file along with its licensing information.
- Updated the generated kit navigation items to include the eSDScom KIT with its corresponding route.
@matbmoser matbmoser self-requested a review as a code owner June 18, 2026 12:39

@matbmoser matbmoser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I have supported you on finding a logo and setting up the KIT structure correctly.

I did not changed any content from the KIT since this is something that I would expect you to do (Since you know more than me)

However I have provided some feedback as an external adopter, and also added some points which normally other KITs are also doing.

I feel that is missing some "valuable" content description here, like some JSON payloads for example. I see the model is not published so I would recommend you to add it here.

I know it is long, but it would bring value if it is at least organized in sections with each payload being available to be seen in JSON format.

You can use <details> tags to hide the payloads so it is easier to read if the files are too big. I have provided some examples how to do it. You can even include it inside code blocks from Markdown.


### Core Semantic Models

[io.catenax.esdscom 1.0.0 extended Safety Data Sheet communication](https://github.com/eclipse-tractusx/sldt-semantic-models/tree/main/io.catenax.esdscom/1.0.0)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link does not exists! There is no published datamodel, and if it would be published this would not be the url.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this model is not published feel free to add it here:

<details>
<summary><strong>Catena-X Safety Datasheet Model Payload</summary>

Add your model here:

...
</details>

"leftOperand": "UsagePurpose",
"operator": "isAnyOf",
"rightOperand": [
"cx.esdscom.base:1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this aligned with the Expert Group from data sovereignty? @DanielaWuensch

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is how we should reference.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was already checked.

@A-KKunert A-KKunert Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was aligned with Daniela Wuensch.

Mail von Freitag, 10. April 2026:
"Hallo Dirk, hallo Anita,

Die Änderung in CX-0152 zum eSDScom purpose sind in diesem PR an dieser Stelle:

https://github.com/catenax-eV/product-standardization-prod/pull/597/changes#diff-b809678ec8be329cbfeb3079b29409b6338f87cce75bab0075355a9931e0b6a9R221

bereit für den Review. Darauf könnt ihr euch dann mit dem rightOperand cx.esdscom.base:1 des Usage Purpose beziehen.

Viele Grüße,
Daniela"


## Tutorials & Resources

Not yet available.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you dont have tutorials just remove it.

Comment thread docs-kits/kits/esdscom-kit/adoption-view/adoption-view.md Outdated
Comment thread docs-kits/kits/esdscom-kit/adoption-view/adoption-view.md Outdated
Comment thread docs-kits/kits/esdscom-kit/development-view/development-view.md Outdated
Comment on lines +152 to +155
### Model Example

Due to the model size, for further information please refer to [esdscom.eu](https://esdscom.eu)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add an example here if you would like, that would give some quality to the documentation.

feel free to add it like this, so it gets "hidden" in a dropdown:

<details>
<summary><strong>XML Safety Datasheet Model</summary>

Add your model here:

...

</details>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirk-qualisys : Could you please add the draft model or the XML here?

@matbmoser

Copy link
Copy Markdown
Contributor

@copilot please find typos

@matbmoser matbmoser requested a review from Copilot June 18, 2026 12:54
@matbmoser matbmoser mentioned this pull request Jun 18, 2026
2 tasks
@matbmoser matbmoser changed the title first updated esds feat: first updated esds communication KIT. Jun 18, 2026
@matbmoser

Copy link
Copy Markdown
Contributor

Please review if the KIT logo is correct and you like it. Added a random color, since this is a different use case than "just sustainability".

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@matbmoser

Copy link
Copy Markdown
Contributor

Policy is correct just confirmed with the DataSov EG. Not sure if we should use Neptune 2026/09/ in the context from json-ld.

Comment on lines +110 to +111
"https://w3id.org/catenax/2025/9/policy/odrl.jsonld",
"https://w3id.org/catenax/2025/9/policy/context.jsonld"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where I meant. @jSchuetz88 is possible to use 2026 here?

@hillmer

hillmer commented Jun 19, 2026

Copy link
Copy Markdown

@matbmoser : we try to eliminate the errors within the ticket but cannot edit. Can you please advice us, how to fork this repository, so that we can work in it?

@matbmoser

Copy link
Copy Markdown
Contributor

@matbmoser : we try to eliminate the errors within the ticket but cannot edit. Can you please advice us, how to fork this repository, so that we can work in it?

ok normally Andrew could edit its own branch in the fork

@matbmoser

Copy link
Copy Markdown
Contributor

I can apply at least the suggestions I have done.

@matbmoser

Copy link
Copy Markdown
Contributor

@Andrew96897 I have applied the edit to the points I have told. The only thing that is missing is to add the data models. @hillmer adding the data models is something that I cant do. I have requested the KIT master builder to do a check for typos and final quality checks.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 13 changed files in this pull request and generated 13 comments.

Comment thread sidebarsDocsKits.js
Comment thread docs-kits/kits/esdscom-kit/changelog.md Outdated
Comment thread docs-kits/kits/esdscom-kit/changelog.md Outdated
Comment thread docs-kits/kits/esdscom-kit/adoption-view/adoption-view.md Outdated
Comment thread docs-kits/kits/esdscom-kit/adoption-view/adoption-view.md Outdated
Comment thread docs-kits/kits/esdscom-kit/development-view/development-view.md Outdated
Comment thread docs-kits/kits/esdscom-kit/development-view/development-view.md Outdated
Comment thread docs-kits/kits/esdscom-kit/development-view/development-view.md Outdated
Comment thread docs-kits/kits/esdscom-kit/development-view/development-view.md Outdated
Comment thread docs-kits/kits/esdscom-kit/development-view/development-view.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment thread docs-kits/kits/esdscom-kit/changelog.md Outdated
Comment on lines +46 to +64
### Changed

- Nothing yet

### Deprecated

- Nothing yet

### Removed

- Nothing yet

### Fixed

- Nothing yet

### Security

- Nothing yet

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This we should remove

"leftOperand": "UsagePurpose",
"operator": "isAnyOf",
"rightOperand": [
"cx.esdscom.base:1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was already checked.


Model: eSDScom
Version: 1.0.0
Namespace: urn:samm:io.catenax.eSDScom:1.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jSchuetz88 could you check here please.

Comment on lines +126 to +132
#### Standards

Technical standards and protocol compliance are not applicable.

#### Tutorials

Developer quick-start guides and code examples are not yet available.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Standards
Technical standards and protocol compliance are not applicable.
#### Tutorials
Developer quick-start guides and code examples are not yet available.

I would take this out, because it does not adds value.

@stephanbcbauer stephanbcbauer linked an issue Jun 29, 2026 that may be closed by this pull request
@stanfaldin

Copy link
Copy Markdown
Contributor

semantic model part updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

Release of eSDScom KIT

6 participants