Make retry configuration align with Maven Resolver properties

- Use aether.connector.http.retryHandler.count for retry attempts (default: 3)
- Use aether.connector.http.retryHandler.interval for retry delay
- Add MavenPropertyHelper to read configuration from Maven properties
- Change default retry count from 5 to 3 to match Maven Resolver defaults

Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>

Author: Copilot

p2-maven-plugin/src/main/java/org/eclipse/tycho/p2maven/transport/Java11HttpTransportFactory.java

@@ -44,6 +44,7 @@
 import org.codehaus.plexus.logging.Logger;
 import org.codehaus.plexus.personality.plexus.lifecycle.phase.Initializable;
 import org.codehaus.plexus.personality.plexus.lifecycle.phase.InitializationException;
+import org.eclipse.tycho.helper.MavenPropertyHelper;
 import org.eclipse.tycho.p2maven.helper.ProxyHelper;
 import org.eclipse.tycho.p2maven.transport.Response.ResponseConsumer;
 
@@ -67,7 +68,13 @@ public class Java11HttpTransportFactory implements HttpTransportFactory, Initial
 			ThreadLocal.withInitial(() -> new SimpleDateFormat("EEE MMMd HH:mm:ss yyyy", Locale.ENGLISH)));
 
 	static final String HINT = "Java11Client";
-	private static final int MAX_RETRY_ATTEMPTS = 5;
+	
+	// Maven Resolver compatible configuration properties
+	private static final String PROP_RETRY_HANDLER_COUNT = "aether.connector.http.retryHandler.count";
+	private static final String PROP_RETRY_HANDLER_INTERVAL = "aether.connector.http.retryHandler.interval";
+	
+	// Default values aligned with Maven Resolver
+	private static final int DEFAULT_MAX_RETRY_ATTEMPTS = 3;
 	private static final int DEFAULT_RETRY_DELAY_SECONDS = 5;
 
 	@Requirement
@@ -76,14 +83,19 @@ public class Java11HttpTransportFactory implements HttpTransportFactory, Initial
 	MavenAuthenticator authenticator;
 	@Requirement
 	Logger logger;
+	@Requirement
+	MavenPropertyHelper propertyHelper;
+	
+	private int maxRetryAttempts;
+	private int retryDelaySeconds;
 
 	private HttpClient client;
 	private HttpClient clientHttp1;
 
 	@Override
 	public HttpTransport createTransport(URI uri) {
 		Java11HttpTransport transport = new Java11HttpTransport(client, clientHttp1, HttpRequest.newBuilder().uri(uri),
-				uri, logger);
+				uri, logger, maxRetryAttempts, retryDelaySeconds);
 		authenticator.preemtiveAuth((k, v) -> transport.setHeader(k, v), uri);
 		return transport;
 	}
@@ -95,13 +107,18 @@ private static final class Java11HttpTransport implements HttpTransport {
 		private Logger logger;
 		private HttpClient clientHttp1;
 		private URI uri;
+		private int maxRetryAttempts;
+		private int retryDelaySeconds;
 
-		public Java11HttpTransport(HttpClient client, HttpClient clientHttp1, Builder builder, URI uri, Logger logger) {
+		public Java11HttpTransport(HttpClient client, HttpClient clientHttp1, Builder builder, URI uri, Logger logger,
+				int maxRetryAttempts, int retryDelaySeconds) {
 			this.client = client;
 			this.clientHttp1 = clientHttp1;
 			this.builder = builder;
 			this.uri = uri;
 			this.logger = logger;
+			this.maxRetryAttempts = maxRetryAttempts;
+			this.retryDelaySeconds = retryDelaySeconds;
 		}
 
 		@Override
@@ -135,7 +152,7 @@ private boolean shouldRetry(int statusCode) {
 		private long getRetryDelay(HttpResponse<?> response) {
 			String retryAfterHeader = response.headers().firstValue("Retry-After").orElse(null);
 			if (retryAfterHeader == null || retryAfterHeader.isBlank()) {
-				return DEFAULT_RETRY_DELAY_SECONDS;
+				return retryDelaySeconds;
 			}
 
 			// Try to parse as seconds (integer)
@@ -162,12 +179,12 @@ private long getRetryDelay(HttpResponse<?> response) {
 			}
 
 			// Default if parsing fails
-			return DEFAULT_RETRY_DELAY_SECONDS;
+			return retryDelaySeconds;
 		}
 
 		private <T> T performGet(ResponseConsumer<T> consumer, HttpClient httpClient)
 				throws IOException, InterruptedException {
-			int retriesLeft = MAX_RETRY_ATTEMPTS;
+			int retriesLeft = maxRetryAttempts;
 			while (retriesLeft > 0) {
 				retriesLeft--;
 				HttpRequest request = builder.GET().timeout(Duration.ofSeconds(TIMEOUT_SECONDS)).build();
@@ -249,7 +266,7 @@ public Response head() throws IOException {
 		}
 
 		private Response doHead(HttpClient httpClient) throws IOException, InterruptedException {
-			int retriesLeft = MAX_RETRY_ATTEMPTS;
+			int retriesLeft = maxRetryAttempts;
 			while (retriesLeft > 0) {
 				retriesLeft--;
 				HttpResponse<Void> response = httpClient.send(
@@ -336,6 +353,21 @@ public long getLastModified() {
 
 	@Override
 	public void initialize() throws InitializationException {
+		// Read retry configuration from Maven properties
+		// Align with Maven Resolver configuration: aether.connector.http.retryHandler.count (default: 3)
+		maxRetryAttempts = propertyHelper.getGlobalIntProperty(PROP_RETRY_HANDLER_COUNT, DEFAULT_MAX_RETRY_ATTEMPTS);
+		
+		// Read retry delay configuration
+		// Maven uses aether.connector.http.retryHandler.interval in milliseconds, we use seconds
+		// Convert from milliseconds to seconds, defaulting to 5 seconds if not set
+		int retryIntervalMs = propertyHelper.getGlobalIntProperty(PROP_RETRY_HANDLER_INTERVAL, DEFAULT_RETRY_DELAY_SECONDS * 1000);
+		retryDelaySeconds = (int) TimeUnit.MILLISECONDS.toSeconds(retryIntervalMs);
+		if (retryDelaySeconds == 0 && retryIntervalMs > 0) {
+			retryDelaySeconds = 1; // Minimum 1 second if interval was set but less than 1 second
+		} else if (retryDelaySeconds == 0) {
+			retryDelaySeconds = DEFAULT_RETRY_DELAY_SECONDS; // Use default if interval is 0
+		}
+		
 		ProxySelector proxySelector = new ProxySelector() {
 
 			@Override