Skip to content

Remove SourceFeatureMojo #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
laeubi wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Remove SourceFeatureMojo #5137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d2597a
Cleanup the REMOVAL.MD as it already was performed
laeubi Jun 12, 2025
67d98ba
Remove SourceFeatureMojo
laeubi Jun 12, 2025
b861e60
Adjust tests for source feature removal
akurtakov Jan 22, 2026
43e4917
Use plexusCompilerVersion variable
akurtakov Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions REMOVAL.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1 @@
## List of removals for next major version of tycho

# the plugin 'tycho-extras/tycho-source-feature-plugin' should be removed on next major release

replaced by core tycho-source

# org.eclipse.tycho.PackagingType.TYPE_ECLIPSE_REPOSITORY and org.eclipse.tycho.PackagingType.TYPE_ECLIPSE_UPDATE_SITE and corresponding mojos

The packagetypes ECLIPSE_REPOSITORY+ECLIPSE_UPDATE_SITE are deprecated for a long time and should be removed, corresponding mojos and code should be dropped also

# drop "fixSWT"

We should simply drop this as the depending bug has be resolved for more than 5 years:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=381167

# drop org.eclipse.tycho.plugins.p2.publisher.PublishProductMojo.flavor

It is marked deprecated for a long time now and should be removed. removal will be backward compatible if this setting is not used.
2 changes: 1 addition & 1 deletion tycho-compiler-plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-compiler-javac</artifactId>
<version>2.16.2</version>
<version>${plexusCompilerVersion}</version>
</dependency>
</dependencies>

Expand Down
4 changes: 1 addition & 3 deletions tycho-its/projects/automaticSourceGeneration/helloworld.updatesite/category.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<site>
<feature id="helloworld.feature" />
<!-- this should be auto generated too ! -->
<feature id="helloworld.feature.source" />
<feature id="helloworld.feature"/>
</site>
6 changes: 0 additions & 6 deletions tycho-its/projects/automaticSourceGeneration/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,6 @@
<goal>plugin-source</goal>
</goals>
</execution>
<execution>
<id>feature-source</id>
<goals>
<goal>feature-source</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
Expand Down
8 changes: 0 additions & 8 deletions tycho-its/projects/feature.attributes.inference/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,6 @@
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-source-plugin</artifactId>
<version>${tycho-version}</version>
<executions>
<execution>
<id>feature-source</id>
<goals>
<goal>feature-source</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
Expand Down
20 changes: 3 additions & 17 deletions tycho-its/projects/reproducible-build/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,29 +65,15 @@
<version>${tycho-version}</version>
<executions>
<execution>
<id>plugin-source</id>
<id>attach-source</id>
<goals>
<goal>plugin-source</goal>
<goal>feature-source</goal>
<goal>plugin-source</goal>
</goals>
<phase>package</phase>
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-p2-plugin</artifactId>
<version>${tycho-version}</version>
<executions>
<execution>
<id>attach-p2-metadata</id>
<phase>package</phase>
<goals>
<goal>p2-metadata</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>

Expand Down
3 changes: 3 additions & 0 deletions tycho-its/projects/reproducible-build/reproducible.repository/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
</goals>
</execution>
</executions>
<configuration>
<includeAllSources>true</includeAllSources>
</configuration>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
Expand Down
4 changes: 0 additions & 4 deletions tycho-its/projects/sourcePlugin/basic/feature.consumingsourcefeature/feature.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,4 @@
id="feature.consumingsourcefeature"
version="1.0.0.qualifier">

<includes
id="sourcefeature.feature.source"
version="0.0.0"/>

</feature>
11 changes: 0 additions & 11 deletions tycho-its/projects/sourcePlugin/basic/sourcefeature.feature.indirect/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,6 @@
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-source-plugin</artifactId>
<version>${tycho-version}</version>
<executions>
<execution>
<id>feature-source</id>
<goals>
<goal>feature-source</goal>
</goals>
<configuration>
<brandingPlugin>sourcefeature.bundle</brandingPlugin>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
Expand Down
14 changes: 0 additions & 14 deletions tycho-its/projects/sourcePlugin/basic/sourcefeature.feature/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,6 @@
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-source-plugin</artifactId>
<version>${tycho-version}</version>
<executions>
<execution>
<id>feature-source</id>
<goals>
<goal>feature-source</goal>
</goals>
<configuration>
<reuseBrandingPlugin>false</reuseBrandingPlugin>
<excludes>
<plugin id="sourcefeature.bundle.nosource"/>
</excludes>
</configuration>
</execution>
</executions>
</plugin>

<plugin>
Expand Down
1 change: 0 additions & 1 deletion ...its/projects/sourcePlugin/basic/sourcefeature.repository/sourcefeature.repository.product
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

<features>
<feature id="sourcefeature.feature" version="1.0.0.qualifier"/>
<feature id="sourcefeature.feature.source" version="1.0.0.qualifier"/>
</features>

</product>
15 changes: 14 additions & 1 deletion tycho-its/projects/sourcePlugin/extra-source-bundles/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
</repositories>

<modules>
<module>extra.sourcefeature.bundle</module>
<module>sourcefeature.feature</module>
<module>sourcefeature.repository</module>
<module>extra.sourcefeature.bundle</module>
</modules>

<build>
Expand Down Expand Up @@ -57,6 +57,19 @@
<referencedRepositoryMode>ignore</referencedRepositoryMode>
</configuration>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-source-plugin</artifactId>
<version>${tycho-version}</version>
<executions>
<execution>
<id>plugin-source</id>
<goals>
<goal>plugin-source</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>

Expand Down
35 changes: 0 additions & 35 deletions tycho-its/projects/sourcePlugin/extra-source-bundles/sourcefeature.feature/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,41 +30,6 @@
</dependency-resolution>
</configuration>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-source-plugin</artifactId>
<version>${tycho-version}</version>
<executions>
<execution>
<id>feature-source</id>
<goals>
<goal>feature-source</goal>
</goals>
<configuration>
<plugins>
<plugin id="extra.sourcefeature.bundle" versionRange="0.0.0" />
</plugins>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-p2-plugin</artifactId>
<version>${tycho-version}</version>
<configuration>
<defaultP2Metadata>false</defaultP2Metadata>
</configuration>
<executions>
<execution>
<id>attached-p2-metadata</id>
<phase>package</phase>
<goals>
<goal>p2-metadata</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
12 changes: 12 additions & 0 deletions tycho-its/projects/sourcePlugin/extra-source-bundles/sourcefeature.repository/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,17 @@

<artifactId>sourcefeature.repository</artifactId>
<packaging>eclipse-repository</packaging>
<build>
<plugins>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-p2-repository-plugin</artifactId>
<version>${tycho-version}</version>
<configuration>
<includeAllSources>true</includeAllSources>
</configuration>
</plugin>
</plugins>
</build>

</project>
7 changes: 5 additions & 2 deletions ...urcePlugin/extra-source-bundles/sourcefeature.repository/sourcefeature.repository.product
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<?pde version="3.5"?>

<product uid="sourcefeature.repository" version="1.0.0.qualifier" useFeatures="true" includeLaunchers="false">
<product uid="sourcefeature.repository" version="1.0.0.qualifier" type="mixed" includeLaunchers="false" autoIncludeRequirements="true">

<plugins>
</plugins>

<features>
<feature id="sourcefeature.feature" version="1.0.0.qualifier"/>
<feature id="sourcefeature.feature.source" version="1.0.0.qualifier"/>
</features>


</product>
1 change: 0 additions & 1 deletion tycho-its/projects/sourcePlugin/license-feature/feature/build.properties
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions tycho-its/projects/sourcePlugin/license-feature/feature/feature.properties
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions tycho-its/projects/sourcePlugin/license-feature/feature/feature.xml
View file
Open in desktop

This file was deleted.

48 changes: 0 additions & 48 deletions tycho-its/projects/sourcePlugin/license-feature/feature/pom.xml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...ts/projects/sourcePlugin/license-feature/feature/sourceTemplateFeature/feature.properties
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tycho-its/projects/sourcePlugin/license-feature/license.feature/build.properties
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions tycho-its/projects/sourcePlugin/license-feature/license.feature/feature.properties
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions tycho-its/projects/sourcePlugin/license-feature/license.feature/feature.xml
View file
Open in desktop

This file was deleted.

Empty file removed tycho-its/projects/sourcePlugin/license-feature/license.feature/license.html
View file
Open in desktop
Empty file.
14 changes: 0 additions & 14 deletions tycho-its/projects/sourcePlugin/license-feature/license.feature/pom.xml
View file
Open in desktop

This file was deleted.

Loading
Loading