Fix for 5886#5887
Conversation
|
@mlehmannm Version bumps are for bundles- not packages... so maybe you want to explain a bit more context. |
|
We develop our software in feature branches which takes sometimes weeks or months. In these feature branches we do not bump versions at all. This happens after merging the feature branches back to develop and right before opening a release branch. We have a script that calls With tycho/5.0.2 we get logs like this
This looks like bogus, because the bundle version has been changed already, but if you look closer/earlier in the log, one can see that bnd suggests changing some package version(s) as well. After 5567 we now have to run This change only restores (via configuration) the previous behaviour. Is there another way to create the necessary changes to the manifests to make the baseline-check happy? |
|
That's tricky - I think here there is a direct suggestion to update a package (what is different to what #5567 aimed for). My expectation would be that this works without adding special configuration - do you think you can try to came up with a reproducer of a problem so we can maybe fix it instead of having a workaround here? |
|
Unfortunately our software is closed-source. But I can provide an excerpt from the build log. See below. The first delta is already the problem. Bnd suggest raising the version for the package to 1.2.0. Tycho seems the treat this version as new bundle-version.
|
|
Is there any chance to merge this simply PR in the near future and to release this as part of tycho 5.0.3? |
|
I can try to take a look but can't promise anything. Beside that, if it is crucial to your business you can find dedicated support options for Tycho here: As mentioned I don't think adding such parameter is useful or should be necessary - and a testcase would still be required in any case. |
|
The VersionEngine already has a test for whether updating packages or not. The PR only makes the option available in the VersionBumpMojo. The change is equally written as changing the increment in the same mojo! |
All test for Tycho currently pass without your change, so whatever issue you see it is obviously not covered by tests. |
Please backport to tycho-5.0.x as well.