Avoid using deprecated sendHead method

Author: vietj

vertx-core/src/main/asciidoc/http.adoc

@@ -1496,7 +1496,7 @@ client request object
 This will be called if the server sends back a `Status: 100 (Continue)` response to signify that it is ok to send
 the rest of the request.
 
-This is used in conjunction with {@link io.vertx.core.http.HttpClientRequest#sendHead()}to send the head of the request.
+This is used in conjunction with {@link io.vertx.core.http.HttpClientRequest#writeHead()} to write the head of the request.
 
 Here's an example:
 

vertx-core/src/main/java/examples/HTTPExamples.java

@@ -1013,7 +1013,7 @@ public void example50(HttpClient client) {
           request.end();
         });
 
-        request.sendHead();
+        request.writeHead();
     });
   }
 

vertx-core/src/main/java/io/vertx/core/http/HttpClientRequest.java

@@ -252,7 +252,7 @@ public interface HttpClientRequest extends WriteStream<Buffer> {
    * has been set using this method, then the {@code handler} will be called.
    * <p>
    * You can then continue to write data to the request body and later end it. This is normally used in conjunction with
-   * the {@link #sendHead()} method to force the request header to be written before the request has ended.
+   * the {@link #writeHead()} method to force the request header to be written before the request has ended.
    *
    * @return a reference to this, so the API can be used fluently
    */
@@ -411,7 +411,7 @@ default Future<HttpClientResponse> send(ReadStream<Buffer> body) {
   Future<Void> end(Buffer chunk);
 
   /**
-   * Ends the request. If no data has been written to the request body, and {@link #sendHead()} has not been called then
+   * Ends the request. If no data has been written to the request body, and {@link #writeHead()} has not been called then
    * the actual request won't get written until this method gets called.
    * <p>
    * Once the request has ended, it cannot be used any more,
@@ -510,7 +510,7 @@ default Future<Void> reset() {
    * The frame is sent immediatly and is not subject to flow control.<p>
    *
    * This method must be called after the request headers have been sent and only for the protocol HTTP/2.
-   * The {@link #sendHead()} should be used for this purpose.
+   * The {@link #writeHead()} should be used for this purpose.
    *
    * @param type the 8-bit frame type
    * @param flags the 8-bit frame flags

vertx-core/src/test/java/io/vertx/tests/http/Http1xTest.java

@@ -1951,7 +1951,7 @@ public void testRequestExceptionHandlerContext() throws Exception {
               assertSameEventLoop(clientCtx, Vertx.currentContext());
               complete();
             }));
-          req.sendHead();
+          req.writeHead();
         }));
     });
     await();
@@ -2077,7 +2077,7 @@ public void testContexts() throws Exception {
               assertSameEventLoop(requestCtx, Vertx.currentContext());
               req.end();
             });
-            req.sendHead().onComplete(version -> {
+            req.writeHead().onComplete(version -> {
               assertSameEventLoop(requestCtx, Vertx.currentContext());
               fill(data, req, cf::complete);
             });
@@ -2796,7 +2796,7 @@ public void testDoNotReuseConnectionWhenResponseEndsBeforeRequest() throws Excep
       // Send head to the server and trigger the request handler
       req
         .setChunked(true)
-        .sendHead();
+        .writeHead();
     }));
 
     client.request(new RequestOptions(requestOptions).setURI("/2"))
@@ -2866,7 +2866,7 @@ public void testClientConnectionExceptionHandler() throws Exception {
       })
       .build();
     client.request(requestOptions)
-      .onComplete(onSuccess(HttpClientRequest::sendHead));
+      .onComplete(onSuccess(HttpClientRequest::writeHead));
     await();
   }
 
@@ -2890,7 +2890,7 @@ public void testServerConnectionExceptionHandler() throws Exception {
         client.request(requestOptions)
           .onComplete(onSuccess(req -> {
             req.putHeader("the_header", TestUtils.randomAlphaString(10000));
-            req.sendHead();
+            req.writeHead();
           }));
       });
     await();
@@ -2911,7 +2911,7 @@ public void testServerExceptionHandler() throws Exception {
     client.request(requestOptions).onComplete(onSuccess(req -> {
       req
         .putHeader("the_header", TestUtils.randomAlphaString(10000))
-        .sendHead();
+        .writeHead();
     }));
     await();
   }
@@ -3087,7 +3087,7 @@ public void testResetKeepAliveClientRequest() throws Exception {
           client.request(requestOptions).onSuccess(req2 -> {
             req2
               .response().onComplete(onFailure(err -> complete()));
-            req2.sendHead().onComplete(onSuccess(v -> {
+            req2.writeHead().onComplete(onSuccess(v -> {
               assertTrue(req2.reset().succeeded());
             }));
           });
@@ -3153,7 +3153,7 @@ public void testResetPipelinedClientRequest() throws Exception {
           .setMethod(HttpMethod.POST)
         ).onComplete(onSuccess(req2 -> {
           req2.response().onComplete(onFailure(resp -> complete()));
-          req2.sendHead();
+          req2.writeHead();
           doReset.thenAccept(v2 -> {
             assertTrue(req2.reset().succeeded());
           });
@@ -3242,11 +3242,11 @@ private void testCloseTheConnectionAfterResetPersistentClientRequest(boolean pip
                   complete();
                 }));
             });
-            req1.sendHead().onComplete(v -> {
+            req1.writeHead().onComplete(v -> {
               assertTrue(req1.reset().succeeded());
             });
           } else {
-            req1.sendHead().onComplete(v -> {
+            req1.writeHead().onComplete(v -> {
               assertTrue(req1.reset().succeeded());
             });
             client.request(new RequestOptions(requestOptions).setURI("/somepath"))
@@ -4440,7 +4440,7 @@ public void testPipeliningQueueDelayed() throws Exception {
     client.request(requestOptions)
       .onComplete(onSuccess(req -> {
         req.response().onComplete(onSuccess(resp -> complete()));
-        req.sendHead();
+        req.writeHead();
         client.request(requestOptions).compose(HttpClientRequest::send).onComplete(resp -> complete());
         client.request(requestOptions).compose(HttpClientRequest::send).onComplete(resp -> complete());
         // Need to wait a little so requests 2 and 3 are appended to the first request
@@ -4570,7 +4570,7 @@ public void testHttpClientRequestShouldCallExceptionHandlerWhenTheClosedHandlerI
           testComplete();
         }
       });
-      req.sendHead().onComplete(onSuccess(v -> {
+      req.writeHead().onComplete(onSuccess(v -> {
         connected.set(true);
         sender.send();
       }));
@@ -4977,7 +4977,7 @@ public void testClientConnectionGracefulShutdownWhenRequestCompletedAfterRespons
             });
           });
         }));
-      req.setChunked(true).sendHead();
+      req.setChunked(true).writeHead();
     }));
     await();
   }
@@ -5535,7 +5535,7 @@ public void testDoNotRecycleWhenRequestIsNotEnded() throws Exception {
           case 0:
             assertTrue(ar.succeeded());
             HttpClientRequest req = ar.result();
-            req.sendHead();
+            req.writeHead();
             req.response().onComplete(onSuccess(resp -> {
               complete();
             }));
@@ -5563,7 +5563,7 @@ public void testRecycleConnectionOnRequestEnd() throws Exception {
     for (int i = 0;i < numRequests;i++) {
       Future<HttpClientRequest> fut = client.request(requestOptions);
       fut.onComplete(onSuccess(request -> {
-        request.setChunked(true).sendHead();
+        request.setChunked(true).writeHead();
         request.response().compose(HttpClientResponse::body).onComplete(onSuccess(v -> {
           vertx.setTimer(10, id -> request.end());
           complete();
@@ -5593,7 +5593,7 @@ public void testFailPendingRequestAllocationWhenConnectionIsClosed() throws Exce
           case 0:
             assertTrue(ar.succeeded());
             HttpClientRequest req = ar.result();
-            req.sendHead();
+            req.writeHead();
             req.response().onComplete(onSuccess(resp -> {
               complete();
             }));

vertx-core/src/test/java/io/vertx/tests/http/Http2ClientTest.java

@@ -1285,7 +1285,7 @@ public void onHeadersRead(ChannelHandlerContext ctx, int streamId, Http2Headers
                 complete();
               }
             })
-            .sendHead();
+            .writeHead();
         }));
       });
       await();
@@ -1341,7 +1341,7 @@ public void onHeadersRead(ChannelHandlerContext ctx, int streamId, Http2Headers
                 complete();
               }
             })
-            .sendHead();
+            .writeHead();
         }));
       });
       await();
@@ -1454,7 +1454,7 @@ public void test100Continue() throws Exception {
           status.getAndIncrement();
           req.end(Buffer.buffer("request-body"));
         });
-        req.sendHead().onComplete(version -> {
+        req.writeHead().onComplete(version -> {
           assertEquals(1, req.streamId());
         });
       }));
@@ -1586,7 +1586,7 @@ public void testServerCloseNetSocket() throws Exception {
   }
 
   @Test
-  public void testSendHeadersCompletionHandler() throws Exception {
+  public void testwriteHeadersCompletionHandler() throws Exception {
     AtomicInteger status = new AtomicInteger();
     server.requestHandler(req -> {
       req.response().end();
@@ -1601,7 +1601,7 @@ public void testSendHeadersCompletionHandler() throws Exception {
             testComplete();
           });
         }));
-      req.sendHead().onComplete(onSuccess(version -> {
+      req.writeHead().onComplete(onSuccess(version -> {
         assertEquals(0, status.getAndIncrement());
         assertSame(HttpVersion.HTTP_2, req.version());
         req.end();
@@ -1642,7 +1642,7 @@ public void testUnknownFrame() throws Exception {
           testComplete();
         });
       }));
-      req.sendHead().onComplete(onSuccess(version -> {
+      req.writeHead().onComplete(onSuccess(version -> {
         assertSame(HttpVersion.HTTP_2, req.version());
         req.writeCustomFrame(10, 253, expectedSend);
         req.end();
@@ -1812,7 +1812,7 @@ private void testIdleTimeout(HttpServerOptions serverOptions, HttpClientOptions
           .exceptionHandler(err -> {
             complete();
           });
-        req.sendHead();
+        req.writeHead();
       }));
     });
     await();
@@ -2179,7 +2179,7 @@ public int onDataRead(ChannelHandlerContext ctx, int streamId, ByteBuf data, int
             });
           }));
         req.setStreamPriority(requestStreamPriority);
-        req.sendHead().onComplete(h -> {
+        req.writeHead().onComplete(h -> {
           req.setStreamPriority(requestStreamPriority2);
           req.end();
         });
@@ -2236,7 +2236,7 @@ public int onDataRead(ChannelHandlerContext ctx, int streamId, ByteBuf data, int
             });
           }));
         req.setStreamPriority(streamPriority);
-        req.sendHead();
+        req.writeHead();
         latch.future().onComplete(onSuccess(v -> {
           req.setStreamPriority(streamPriority);
           req.end();

vertx-core/src/test/java/io/vertx/tests/http/Http2Test.java

@@ -141,7 +141,7 @@ public void testServerResponseResetFromOtherThread() throws Exception {
           assertTrue(err instanceof StreamResetException);
           complete();
         })
-        .sendHead();
+        .writeHead();
     }));
     await();
   }
@@ -176,7 +176,7 @@ public void testClientRequestWriteFromOtherThread() throws Exception {
         }));
         req
           .setChunked(true)
-          .sendHead();
+          .writeHead();
         new Thread(() -> {
           try {
             awaitLatch(latch2); // The next write won't be buffered
@@ -498,7 +498,7 @@ public void testStreamWeightAndDependencyChange() throws Exception {
           complete();
         }));
       req
-        .sendHead()
+        .writeHead()
         .onComplete(h -> {
           req.setStreamPriority(new StreamPriority()
             .setDependency(requestStreamDependency2)
@@ -543,7 +543,7 @@ public void testServerStreamPriorityNoChange() throws Exception {
         .setWeight(weight)
         .setExclusive(exclusive));
       req
-        .sendHead()
+        .writeHead()
         .onComplete(h -> {
         req.setStreamPriority(new StreamPriority()
           .setDependency(dependency)
@@ -778,7 +778,7 @@ public void testClearTextUpgradeWithBodyTooLongFrameResponse() throws Exception
           testComplete();
         }
       });
-      req.sendHead();
+      req.writeHead();
     }));
     await();
   }
@@ -954,7 +954,7 @@ public void testStreamResetErrorMapping() throws Exception {
         testComplete();
       });
       // Force stream allocation
-      req.sendHead().onComplete(onSuccess(v -> {
+      req.writeHead().onComplete(onSuccess(v -> {
         req.reset(10);
       }));
     }));

vertx-core/src/test/java/io/vertx/tests/http/HttpClientTimeoutTest.java

@@ -239,7 +239,7 @@ public void testHttpClientRequestTimeoutResetsTheConnection() throws Exception {
       req.response().onComplete(onFailure(err -> {
         complete();
       }));
-      req.setChunked(true).sendHead().onComplete(onSuccess(version -> req.idleTimeout(500)));
+      req.setChunked(true).writeHead().onComplete(onSuccess(version -> req.idleTimeout(500)));
       AtomicBoolean errored = new AtomicBoolean();
       req.exceptionHandler(err -> {
         if (errored.compareAndSet(false, true)) {
@@ -289,7 +289,7 @@ public void testResponseDataTimeout() throws Exception {
           complete();
         }
       });
-      req.sendHead();
+      req.writeHead();
     }));
     await();
   }