Correctly add the idle state handler to a NetSocket when using SSL.

Motivation:

TLS NetSocket sets the idle state handler after the chunked write handler which more aggressively closes connections when sending a large file.

Changes:

When configuring a NetSocket, add the idle state handler after the chunked write handler.

Add HTTP TLS send file tests.

Author: vietj

vertx-core/src/main/java/io/vertx/core/net/impl/NetServerImpl.java

@@ -266,16 +266,16 @@ protected void initChannel(ChannelPipeline pipeline, boolean ssl) {
     if (options.getLogActivity()) {
       pipeline.addLast("logging", new LoggingHandler(options.getActivityLogDataFormat()));
     }
-    if (ssl || !options.isFileRegionEnabled() || !vertx.transport().supportFileRegion() || (options.getTrafficShapingOptions() != null && options.getTrafficShapingOptions().getOutboundGlobalBandwidth() > 0)) {
-      // only add ChunkedWriteHandler when SSL is enabled or FileRegion isn't supported or when outbound traffic shaping is enabled
-      pipeline.addLast("chunkedWriter", new ChunkedWriteHandler());       // For large file / sendfile support
-    }
     int idleTimeout = options.getIdleTimeout();
     int readIdleTimeout = options.getReadIdleTimeout();
     int writeIdleTimeout = options.getWriteIdleTimeout();
     if (idleTimeout > 0 || readIdleTimeout > 0 || writeIdleTimeout > 0) {
       pipeline.addLast("idle", new IdleStateHandler(readIdleTimeout, writeIdleTimeout, idleTimeout, options.getIdleTimeoutUnit()));
     }
+    if (ssl || !options.isFileRegionEnabled() || !vertx.transport().supportFileRegion() || (options.getTrafficShapingOptions() != null && options.getTrafficShapingOptions().getOutboundGlobalBandwidth() > 0)) {
+      // only add ChunkedWriteHandler when SSL is enabled or FileRegion isn't supported or when outbound traffic shaping is enabled
+      pipeline.addLast("chunkedWriter", new ChunkedWriteHandler());       // For large file / sendfile support
+    }
   }
 
   protected GlobalTrafficShapingHandler createTrafficShapingHandler() {

vertx-core/src/test/java/io/vertx/tests/http/sendfile/Http1xSendFileTest.java

@@ -16,6 +16,7 @@
 import io.vertx.core.http.HttpServerOptions;
 import io.vertx.core.http.PoolOptions;
 import io.vertx.core.impl.Utils;
+import io.vertx.core.net.NetClientOptions;
 import io.vertx.test.core.TestUtils;
 import org.junit.Assume;
 import org.junit.Test;
@@ -48,7 +49,11 @@ public void testSendFileFailsWhenClientClosesConnection() throws Exception {
       }
     });
     startServer(testAddress);
-    vertx.createNetClient().connect(testAddress).onComplete(onSuccess(socket -> {
+    vertx.createNetClient(new NetClientOptions()
+      .setSsl(createBaseClientOptions().isSsl())
+      .setHostnameVerificationAlgorithm("")
+      .setTrustAll(true)
+    ).connect(testAddress).onComplete(onSuccess(socket -> {
       socket.write("GET / HTTP/1.1\r\n\r\n");
       socket.close();
     }));
@@ -101,14 +106,8 @@ private int retrieveFileFromServer(File file, HttpServerOptions options) throws
         });
     startServer(testAddress);
     long now = System.currentTimeMillis();
-    Integer len = getFile().await();
-    assertEquals((int)len, file.length());
-    return (int) (System.currentTimeMillis() - now);
-  }
-
-  private Future<Integer> getFile() {
     int[] length = {0};
-    return client.request(requestOptions)
+    Integer len = client.request(requestOptions)
       .compose(req -> req.send()
         .compose(resp -> {
           resp.handler(buff -> {
@@ -121,7 +120,8 @@ private Future<Integer> getFile() {
           resp.exceptionHandler(this::fail);
           return resp.end();
         }))
-      .map(v -> length[0]);
+      .map(v -> length[0]).await();
+    assertEquals((int)len, file.length());
+    return (int) (System.currentTimeMillis() - now);
   }
-
 }

vertx-core/src/test/java/io/vertx/tests/http/sendfile/Http1xTLSSendFileTest.java

@@ -0,0 +1,28 @@
+/*
+ * Copyright (c) 2011-2025 Contributors to the Eclipse Foundation
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License 2.0 which is available at
+ * http://www.eclipse.org/legal/epl-2.0, or the Apache License, Version 2.0
+ * which is available at https://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * SPDX-License-Identifier: EPL-2.0 OR Apache-2.0
+ */
+package io.vertx.tests.http.sendfile;
+
+import io.vertx.core.http.HttpClientOptions;
+import io.vertx.core.http.HttpServerOptions;
+import io.vertx.test.tls.Cert;
+
+public class Http1xTLSSendFileTest extends Http1xSendFileTest {
+
+  @Override
+  protected HttpServerOptions createBaseServerOptions() {
+    return super.createBaseServerOptions().setSsl(true).setKeyCertOptions(Cert.SERVER_JKS.get());
+  }
+
+  @Override
+  protected HttpClientOptions createBaseClientOptions() {
+    return super.createBaseClientOptions().setSsl(true).setTrustAll(true);
+  }
+}

vertx-core/src/test/java/io/vertx/tests/http/sendfile/HttpSendFileTest.java

@@ -354,7 +354,7 @@ public void testSendFileWithRandomAccessFileRange() throws Exception {
 
   private RandomAccessFile testSendFileWithFileChannel(int flen, BiFunction<RandomAccessFile, HttpServerResponse, Future<?>> sender,
                                                        String expectedContentType, long expectedLength) throws Exception {
-    Assume.assumeTrue(this instanceof Http1xSendFileTest);
+    Assume.assumeTrue(this.getClass() == Http1xSendFileTest.class);
     File file = TestUtils.tmpFile(".dat", flen);
     RandomAccessFile raf = new RandomAccessFile(file, "r");
     server.requestHandler(req -> sender.apply(raf, req.response()).onComplete(onSuccess(v -> testComplete())));