WebSocketServerConfig and HttpCompressionConfig should be null

Author: vietj

vertx-core/src/main/java/io/vertx/core/http/HttpServerConfig.java

@@ -83,16 +83,21 @@ private static TcpServerConfig defaultTcpServerConfig() {
    */
   public HttpServerConfig(HttpServerOptions options) {
 
-    List<CompressionOptions> compressors = options.getCompression().getCompressors();
-    if (compressors == null) {
-      int compressionLevel = options.getCompressionLevel();
-      compressors = Arrays.asList(StandardCompressionOptions.gzip(compressionLevel, 15, 8), StandardCompressionOptions.deflate(compressionLevel, 15, 8));
+    HttpCompressionConfig compression;
+    if (options.isCompressionSupported() || options.isDecompressionSupported()) {
+      List<CompressionOptions> compressors = options.getCompression().getCompressors();
+      if (compressors == null) {
+        int compressionLevel = options.getCompressionLevel();
+        compressors = Arrays.asList(StandardCompressionOptions.gzip(compressionLevel, 15, 8), StandardCompressionOptions.deflate(compressionLevel, 15, 8));
+      }
+      compression = new HttpCompressionConfig();
+      compression.setCompressionEnabled(options.isCompressionSupported());
+      compression.setDecompressionEnabled(options.isDecompressionSupported());
+      compression.setContentSizeThreshold(options.getCompressionContentSizeThreshold());
+      compression.setCompressors(compressors);
+    } else {
+      compression = null;
     }
-    HttpCompressionConfig compression = new HttpCompressionConfig();
-    compression.setCompressionEnabled(options.isCompressionSupported());
-    compression.setDecompressionEnabled(options.isDecompressionSupported());
-    compression.setContentSizeThreshold(options.getCompressionContentSizeThreshold());
-    compression.setCompressors(compressors);
 
     this.versions = EnumSet.copyOf(DEFAULT_VERSIONS);
     this.maxFormAttributeSize = options.getMaxFormAttributeSize();
@@ -125,8 +130,8 @@ public HttpServerConfig() {
     this.http1Config = null;
     this.http2Config = null;
     this.http3Config = null;
-    this.webSocketConfig = new WebSocketServerConfig();
-    this.compression = new HttpCompressionConfig();
+    this.webSocketConfig = null;
+    this.compression = null;
     this.tcpConfig = defaultTcpServerConfig();
     this.quicConfig = defaultQuicConfig();
   }

vertx-core/src/main/java/io/vertx/core/http/impl/tcp/TcpHttpServer.java

@@ -206,7 +206,7 @@ public synchronized Future<HttpServer> listen(ContextInternal context, SocketAdd
     HttpCompressionConfig compression = config.getCompression();
     ServerSSLOptions sslOptions = configureSSLOptions(config, this.sslOptions);
     NetServerInternal server = new NetServerBuilder(vertx, config.getTcpConfig(), sslOptions)
-      .fileRegionEnabled(!compression.isCompressionEnabled())
+      .fileRegionEnabled(compression == null || !compression.isCompressionEnabled())
       .cleanable(false)
       .protocol("http")
       .build();
@@ -230,7 +230,7 @@ public synchronized Future<HttpServer> listen(ContextInternal context, SocketAdd
         exceptionHandler,
         config.getHttp2Config().getConnectionWindowSize());
 
-      List<CompressionOptions> compressors = compression.getCompressors();
+      List<CompressionOptions> compressors = compression != null ? compression.getCompressors() : null;
       HttpServerConnectionInitializer initializer = new HttpServerConnectionInitializer(
         listenContext,
         context.threadingModel(),
@@ -242,7 +242,7 @@ public synchronized Future<HttpServer> listen(ContextInternal context, SocketAdd
         config.getTracingPolicy(),
         config.getTcpConfig().getNetworkLogging() != null,
         compressors != null ? compressors.toArray(new CompressionOptions[0]) : null,
-        compression.getContentSizeThreshold(),
+        compression != null ? compression.getContentSizeThreshold() : 0,
         config.isHandle100ContinueAutomatically(),
         config.getMaxFormAttributeSize(),
         config.getMaxFormFields(),