Skip to content

Commit 8e05f2b

Browse files
committed
Rename test build properties.
Motivation: The useModulePath property for testing is now provided by vertx5-parent and is named vertx.surefire.useModulePath. Rename vertx-core specific properties to follow the same pattern. Changes: - vertx.testUseDomainSockets -> vertx.surefire.useDomainSockets - vertx.testTransport -> vertx.surefire.nettyTransport - update README accordingly
1 parent 4b44d70 commit 8e05f2b

File tree

2 files changed

+22
-21
lines changed

2 files changed

+22
-21
lines changed

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,18 @@ Tests can be run with specified HTTP port and/or HTTPS port.
3232
Vert.x supports native transport on BSD and Linux, to run the tests with native transport
3333

3434
```
35-
> mvn test -PtestNativeTransport
35+
> mvn test -PNativeEpoll
36+
> mvn test -PNativeIoUring
37+
> mvn test -PNativeKQueue
3638
```
3739

3840
Vert.x supports domain sockets on Linux exclusively, to run the tests with domain sockets
3941

4042
```
41-
> mvn test -PtestDomainSockets
43+
> mvn test -PNativeEpoll+DomainSockets
4244
```
4345

44-
Vert.x has a few integrations tests that run a differently configured JVM (classpath, system properties, etc....)
45-
for ALPN, native and logging
46+
Vert.x has integrations tests that run a differently configured JVM (classpath, system properties, etc....)
4647

4748
```
4849
> vertx verify -Dtest=FooTest # FooTest does not exists, its only purpose is to execute no tests during the test phase

vertx-core/pom.xml

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
<apacheds-protocol-dns.version>2.0.0.AM27</apacheds-protocol-dns.version>
3030
<generated.dir>${project.basedir}/src/main/generated</generated.dir>
3131
<jmh.version>1.37</jmh.version>
32-
<vertx.testTransport>jdk</vertx.testTransport>
33-
<vertx.testDomainSockets>false</vertx.testDomainSockets>
32+
<vertx.surefire.nettyTransport>jdk</vertx.surefire.nettyTransport>
33+
<vertx.surefire.useDomainSockets>false</vertx.surefire.useDomainSockets>
3434
</properties>
3535

3636
<dependencies>
@@ -252,8 +252,8 @@
252252
<buildDirectory>${project.build.directory}</buildDirectory>
253253
<vertx.version>${project.version}</vertx.version>
254254
<vertx.handle100Continue>true</vertx.handle100Continue>
255-
<vertx.transport>${vertx.testTransport}</vertx.transport>
256-
<vertx.useDomainSockets>${vertx.testDomainSockets}</vertx.useDomainSockets>
255+
<vertx.transport>${vertx.surefire.nettyTransport}</vertx.transport>
256+
<vertx.useDomainSockets>${vertx.surefire.useDomainSockets}</vertx.useDomainSockets>
257257
<vertx.threadChecks>true</vertx.threadChecks>
258258
</systemPropertyVariables>
259259
<!-- Needs to be small enough to run in a EC2 1.7GB small instance -->
@@ -696,45 +696,45 @@
696696
<profile>
697697
<id>NativeEpoll</id>
698698
<properties>
699-
<vertx.testTransport>epoll</vertx.testTransport>
700-
<vertx.testDomainSockets>false</vertx.testDomainSockets>
701-
<vertx.testUseModulePath>false</vertx.testUseModulePath>
699+
<vertx.surefire.nettyTransport>epoll</vertx.surefire.nettyTransport>
700+
<vertx.surefire.useDomainSockets>false</vertx.surefire.useDomainSockets>
701+
<vertx.surefire.useModulePath>false</vertx.surefire.useModulePath>
702702
</properties>
703703
</profile>
704704

705705
<profile>
706706
<id>NativeIoUring</id>
707707
<properties>
708-
<vertx.testTransport>io_uring</vertx.testTransport>
709-
<vertx.testDomainSockets>false</vertx.testDomainSockets>
708+
<vertx.surefire.nettyTransport>io_uring</vertx.surefire.nettyTransport>
709+
<vertx.surefire.useDomainSockets>false</vertx.surefire.useDomainSockets>
710710
<vertx.surefire.useModulePath>false</vertx.surefire.useModulePath>
711711
</properties>
712712
</profile>
713713

714714
<profile>
715715
<id>NativeEpoll+DomainSockets</id>
716716
<properties>
717-
<vertx.testTransport>epoll</vertx.testTransport>
718-
<vertx.testDomainSockets>true</vertx.testDomainSockets>
717+
<vertx.surefire.nettyTransport>epoll</vertx.surefire.nettyTransport>
718+
<vertx.surefire.useDomainSockets>true</vertx.surefire.useDomainSockets>
719719
<vertx.surefire.useModulePath>false</vertx.surefire.useModulePath>
720720
</properties>
721721
</profile>
722722

723723
<profile>
724724
<id>NativeKQueue</id>
725725
<properties>
726-
<vertx.testTransport>kqueue</vertx.testTransport>
727-
<vertx.testDomainSockets>false</vertx.testDomainSockets>
728-
<vertx.testUseModulePath>false</vertx.testUseModulePath>
726+
<vertx.surefire.nettyTransport>kqueue</vertx.surefire.nettyTransport>
727+
<vertx.surefire.useDomainSockets>false</vertx.surefire.useDomainSockets>
728+
<vertx.surefire.useModulePath>false</vertx.surefire.useModulePath>
729729
</properties>
730730
</profile>
731731

732732
<profile>
733733
<id>NativeKQueue+DomainSockets</id>
734734
<properties>
735-
<vertx.testTransport>kqueue</vertx.testTransport>
736-
<vertx.testDomainSockets>true</vertx.testDomainSockets>
737-
<vertx.testUseModulePath>false</vertx.testUseModulePath>
735+
<vertx.surefire.nettyTransport>kqueue</vertx.surefire.nettyTransport>
736+
<vertx.surefire.useDomainSockets>true</vertx.surefire.useDomainSockets>
737+
<vertx.surefire.useModulePath>false</vertx.surefire.useModulePath>
738738
</properties>
739739
</profile>
740740

0 commit comments

Comments
 (0)