HTTP config nested per versions config should initially be null.

Author: vietj

vertx-core/src/main/java/io/vertx/core/http/HttpClientConfig.java

@@ -85,9 +85,9 @@ public HttpClientConfig() {
     this.quicConfig = defaultQuicConfig();
     this.ssl = TCPSSLOptions.DEFAULT_SSL;
     this.versions = new ArrayList<>(DEFAULT_SUPPORTED_VERSIONS);
-    this.http1Config = new Http1ClientConfig();
-    this.http2Config = new Http2ClientConfig();
-    this.http3Config = new Http3ClientConfig();
+    this.http1Config = null;
+    this.http2Config = null;
+    this.http3Config = null;
     this.verifyHost = HttpClientOptions.DEFAULT_VERIFY_HOST;
     this.decompressionEnabled = HttpClientOptions.DEFAULT_DECOMPRESSION_SUPPORTED;
     this.defaultHost = HttpClientOptions.DEFAULT_DEFAULT_HOST;

vertx-core/src/main/java/io/vertx/core/http/HttpServerConfig.java

@@ -112,9 +112,9 @@ public HttpServerConfig() {
     this.strictThreadMode = HttpServerOptions.DEFAULT_STRICT_THREAD_MODE_STRICT;
     this.metricsName = null;
     this.tracingPolicy = HttpServerOptions.DEFAULT_TRACING_POLICY;
-    this.http1Config = new Http1ServerConfig();
-    this.http2Config = new Http2ServerConfig();
-    this.http3Config = new Http3ServerConfig();
+    this.http1Config = null;
+    this.http2Config = null;
+    this.http3Config = null;
     this.webSocketConfig = new WebSocketServerConfig();
     this.compression = new HttpCompressionConfig();
     this.tcpConfig = defaultTcpServerConfig();

vertx-core/src/main/java/io/vertx/core/http/impl/quic/QuicHttpClientTransport.java

@@ -12,6 +12,7 @@
 
 import io.netty.handler.codec.http3.Http3;
 import io.vertx.core.Future;
+import io.vertx.core.http.Http3ClientConfig;
 import io.vertx.core.http.Http3Settings;
 import io.vertx.core.http.HttpClientConfig;
 import io.vertx.core.http.impl.HttpClientConnection;
@@ -43,15 +44,20 @@ public QuicHttpClientTransport(VertxInternal vertx, HttpClientConfig config) {
     QuicClientConfig quicConfig = new QuicClientConfig(config.getQuicConfig());
     quicConfig.setMetricsName(config.getMetricsName());
 
-    Http3Settings localSettings = config.getHttp3Config().getInitialSettings();
+    Http3ClientConfig http3Config = config.getHttp3Config();
+    if (http3Config == null) {
+      http3Config = new Http3ClientConfig();
+    }
+
+    Http3Settings localSettings = http3Config.getInitialSettings();
     if (localSettings == null) {
       localSettings = new Http3Settings();
     }
 
     QuicClient client = new QuicClientImpl(vertx, quicConfig, "http", null);
 
     this.vertx = vertx;
-    this.keepAliveTimeoutMillis = config.getHttp3Config().getKeepAliveTimeout() == null ? 0L : config.getHttp3Config().getKeepAliveTimeout().toMillis();
+    this.keepAliveTimeoutMillis = http3Config.getKeepAliveTimeout() == null ? 0L : http3Config.getKeepAliveTimeout().toMillis();
     this.localSettings = localSettings;
     this.client = client;
   }

vertx-core/src/test/java/io/vertx/tests/http/HttpClientConfigTest.java

@@ -24,9 +24,9 @@ public class HttpClientConfigTest {
   @Test
   public void testDefaultConfig() {
     HttpClientConfig config = new HttpClientConfig();
-    assertNotNull(config.getHttp1Config());
-    assertNotNull(config.getHttp2Config());
-    assertNotNull(config.getHttp3Config());
+    assertNull(config.getHttp1Config());
+    assertNull(config.getHttp2Config());
+    assertNull(config.getHttp3Config());
     assertFalse(config.isSsl());
     assertEquals(List.of(HTTP_1_1, HTTP_2), config.getVersions());
   }

vertx-core/src/test/java/io/vertx/tests/http/http3/Http3ClientTest.java

@@ -419,11 +419,11 @@ public void testSettings() throws Exception {
 
     client.close();
     HttpClientConfig config = new HttpClientConfig(clientConfig);
-    config.getHttp3Config().setInitialSettings(new Http3Settings()
-      .setMaxFieldSectionSize(1024)
-      .setQPackBlockedStreams(1024)
-      .setQPackMaxTableCapacity(1024)
-    );
+    config.setHttp3Config(new Http3ClientConfig()
+      .setInitialSettings(new Http3Settings()
+        .setMaxFieldSectionSize(1024)
+        .setQPackBlockedStreams(1024)
+        .setQPackMaxTableCapacity(1024)));
     client = vertx.createHttpClient(config, clientSSLOptions);
 
     HttpClientConnection connection = client.connect(new HttpConnectOptions()

vertx-core/src/test/java/io/vertx/tests/http/http3/Http3Config.java

@@ -109,10 +109,12 @@ public HttpServer create(Vertx vertx) {
 
   @Override
   public HttpClientConfig forClient() {
+    Http3ClientConfig http3Config = new Http3ClientConfig();
     io.vertx.core.http.HttpClientConfig config = new io.vertx.core.http.HttpClientConfig();
     config.setVersions(List.of(HttpVersion.HTTP_3));
     config.setDefaultHost(host);
     config.setDefaultPort(port);
+    config.setHttp3Config(http3Config);
     ClientSSLOptions sslOptions = new ClientSSLOptions()
       .setTrustOptions(Trust.SERVER_JKS.get())
       .setHostnameVerificationAlgorithm("");
@@ -146,7 +148,7 @@ public HttpClientConfig setIdleTimeout(Duration timeout) {
       }
       @Override
       public HttpClientConfig setKeepAliveTimeout(Duration timeout) {
-        config.getHttp3Config().setKeepAliveTimeout(timeout.toMillis() > 0 ? timeout : null);
+        http3Config.setKeepAliveTimeout(timeout.toMillis() > 0 ? timeout : null);
         return this;
       }
       @Override

vertx-core/src/test/java/io/vertx/tests/http/http3/Http3ServerTest.java

@@ -397,13 +397,12 @@ public void testStreamIdleTimeout() throws Exception {
 
   @Test
   public void testSettings() throws Exception {
-    HttpServerConfig config = serverConfig();
-    config.getHttp3Config()
-      .setInitialSettings(new io.vertx.core.http.Http3Settings()
-      .setMaxFieldSectionSize(1024)
-      .setQPackBlockedStreams(1024)
-      .setQPackMaxTableCapacity(1024)
-    );
+    HttpServerConfig config = serverConfig()
+      .setHttp3Config(new Http3ServerConfig()
+        .setInitialSettings(new io.vertx.core.http.Http3Settings()
+          .setMaxFieldSectionSize(1024)
+          .setQPackBlockedStreams(1024)
+          .setQPackMaxTableCapacity(1024)));
     server = vertx.createHttpServer(config, sslOptions());
 
     server.connectionHandler(connection -> {