Skip to content

Revert "Work around HTTP/2 decompression padding issue." #6078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vietj merged 1 commit into from
Apr 17, 2026
+1 −15
Merged

Revert "Work around HTTP/2 decompression padding issue." #6078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions vertx-core/src/main/java/io/vertx/core/http/impl/VertxHttp2ConnectionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ class VertxHttp2ConnectionHandler<C extends Http2ConnectionBase> extends Http2Co
private final boolean useDecompressor;
private final Http2Settings initialSettings;
public boolean upgraded;
private final Http2LocalFlowController defaultController;

public VertxHttp2ConnectionHandler(
Function<VertxHttp2ConnectionHandler<C>, C> connectionFactory,
Expand All @@ -54,7 +53,6 @@ public VertxHttp2ConnectionHandler(
Http2ConnectionEncoder encoder,
Http2Settings initialSettings) {
super(decoder, encoder, initialSettings);
this.defaultController = decoder.flowController();
this.connectionFactory = connectionFactory;
this.useDecompressor = useDecompressor;
this.initialSettings = initialSettings;
Expand Down Expand Up @@ -388,19 +386,7 @@ public void onSettingsAckRead(ChannelHandlerContext ctx) throws Http2Exception {
@Override
public void onSettingsRead(ChannelHandlerContext ctx, Http2Settings settings) throws Http2Exception {
if (useDecompressor) {
decoder().frameListener(new DelegatingDecompressorFrameListener(decoder().connection(), connection) {
@Override
public int onDataRead(ChannelHandlerContext ctx, int streamId, ByteBuf data, int padding, boolean endOfStream) throws Http2Exception {
// Work around padded decompression
// this should be removed when response decompression is fixed
if (padding > 0) {
VertxHttp2Stream<?> stream = connection.stream(streamId);
defaultController.consumeBytes(stream.stream, padding);
padding = 0;
}
return super.onDataRead(ctx, streamId, data, padding, endOfStream);
}
});
decoder().frameListener(new DelegatingDecompressorFrameListener(decoder().connection(), connection));
} else {
decoder().frameListener(connection);
}
Expand Down
Loading