Skip to content

Allow zero HTTP/2 keep-alive timeout #6214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shblue21 wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

Allow zero HTTP/2 keep-alive timeout #6214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vertx-core/src/main/java/io/vertx/core/http/Http2ClientConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public Duration getKeepAliveTimeout() {
* @return a reference to this, so the API can be used fluently
*/
public Http2ClientConfig setKeepAliveTimeout(Duration keepAliveTimeout) {
if (keepAliveTimeout != null && (keepAliveTimeout.isNegative() || keepAliveTimeout.isZero())) {
if (keepAliveTimeout != null && (keepAliveTimeout.isNegative())) {
throw new IllegalArgumentException("HTTP/2 keepAliveTimeout must be >= 0");
}
this.keepAliveTimeout = keepAliveTimeout;
Expand Down
10 changes: 10 additions & 0 deletions vertx-core/src/test/java/io/vertx/tests/http/HttpClientConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@

import io.vertx.core.http.HttpClientOptions;
import io.vertx.core.http.HttpClientConfig;
import io.vertx.core.http.Http2ClientConfig;
import org.junit.Test;

import java.time.Duration;
import java.util.List;

import static io.vertx.core.http.HttpVersion.*;
Expand Down Expand Up @@ -60,4 +62,12 @@ public void testFromHttp1_0Options() {
assertFalse(config.isSsl());
assertEquals(List.of(HTTP_1_0), config.getVersions());
}

@Test
public void testHttp2KeepAliveTimeoutValidation() {
Http2ClientConfig config = new Http2ClientConfig();
assertSame(config, config.setKeepAliveTimeout(Duration.ZERO));
assertEquals(Duration.ZERO, config.getKeepAliveTimeout());
assertThrows(IllegalArgumentException.class, () -> config.setKeepAliveTimeout(Duration.ofMillis(-1)));
}
}
Loading