Add option including JSON default value for transcoding#252
Draft
mutexd wants to merge 1 commit intoeclipse-vertx:5.0from
Draft
Add option including JSON default value for transcoding#252mutexd wants to merge 1 commit intoeclipse-vertx:5.0from
mutexd wants to merge 1 commit intoeclipse-vertx:5.0from
Conversation
Author
|
If the approach taken doesn't align with the structure of the project, I would like to delete this PR and create an issue. A feedback would be appreciated. |
Member
|
Hello, thank you for the contribution. I think it would be better to convert this to a draft and open an issue so it can be discussed, more in depth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
I'm using grpc-transcoding so that I can have one grpc-service implementation which can serve both Grpc/REST entry point. However, the JsonPrinter's default behavior excludes default values such as int32:0, string:"". Therefore, a GrpcResponse with
{ "message": "Hello", "status": 0 }will become like this for REST response.
{ "message": "Hello" }Even though it's valid in terms of ProtoJSON, it would be nice to have default values because JSON in REST conventionally includes default value like this.
Draft for #261 (need discussion)
Adds a flag for
vertx-grpc-protoc-plugin2and directly embedsprinter.includingDefaultValueFields()into transcoding'sencodermethod. Changing theServiceMethodsignature should be avoided and therefore I approach the issue fromvertx-grpc-protoc-plugin2.