Add support for WireFormat configuration by zZHorizonZz · Pull Request #266 · eclipse-vertx/vertx-grpc

zZHorizonZz · 2026-05-04T06:11:29Z

Motivation:

Allow customization of JSON printer and parser configurations for gRPC transcoding trough WireFormat configuration.

Changes:

Added ability to configure supported wireformats on server.
Added JsonWireFormat and ProtobufWireFormat as concrete implementations of WireFormat.
Updated GrpcMessageEncoder and GrpcMessageDecoder to respect custom wire formats.
Added ProtobufJsonReader and ProtobufJsonWriter.
Updated transcoding logic to use specific wire formats.

Closes: #261
Supersedes: #252

zZHorizonZz · 2026-05-04T06:22:23Z

@mutexd If you want you can also review, I think this should allow more configuration in the future

mutexd · 2026-05-11T09:29:59Z

@mutexd If you want you can also review, I think this should allow more configuration in the future

It looks good to me. I also tried it out and it works just as expected. Thanks.

vietj · 2026-06-04T09:07:03Z

we should move ProtobufJsonReader and ProtobufJsonWriter to impl package and not expose this for the moment, and we open it to module that actually use it, I want to keep the surface API small

vietj · 2026-06-04T15:09:59Z

      return 415;
    }

+    if (!options.isFormatEnabled(details.format)) {


is that case tested ?

It is vertx-grpc-server/src/test/java/io/vertx/tests/server/FormatSupportTest.java

- Allow customization of JSON printer and parser configurations for gRPC transcoding trough WireFormat configuration. Changes: - Added ability to configure supported wireformats on server. - Added `JsonWireFormat` and `ProtobufWireFormat` as concrete implementations of `WireFormat`. - Updated `GrpcMessageEncoder` and `GrpcMessageDecoder` to respect custom wire formats. - Added `ProtobufJsonReader` and `ProtobufJsonWriter`. - Updated transcoding logic to use specific wire formats. Signed-off-by: Daniel Fiala <danfiala23@gmail.com>

Motivation: - Simplify API for configuring JSON reader and writer flags in `JsonWireFormat`. Changes: - Replaced `WriterConfig` and `ReaderConfig` with direct boolean flags in `JsonWireFormat`. - Updated `GrpcMessageEncoder` and `GrpcMessageDecoder` to use the simplified `JsonWireFormat`. - Refactored `ProtobufJsonWriter` and `ProtobufJsonReader` to accept simplified `JsonWireFormat`. - Updated tests to use the new `JsonWireFormat` flag-based API. - Removed unused configuration classes and redundant imports. Signed-off-by: Daniel Fiala <danfiala23@gmail.com>

…and extensibility. Motivation: - Improve readability and ensure robust handling of `WireFormat` values in EventBus gRPC server implementation. Changes: - Refactored validation and parsing of the `grpc-wire-format` header in `EventBusGrpcServerImpl` to handle unknown formats gracefully. - Replaced hardcoded string comparisons with `WireFormat` enumeration values in tests and implementation. - Updated `dispatch` method to accept `WireFormat` directly, simplifying usage. - Adjusted related JavaDocs for better description of `grpc-wire-format`.

Motivation: - Align method names with standard practices by removing the `get` prefix for boolean accessors to enhance readability and maintain consistency across the codebase. Changes: - Renamed all `get*` methods to remove the `get` prefix in `JsonWireFormat`. - Updated `ProtobufJsonWriterImpl` and `ProtobufJsonReaderImpl` to use the renamed methods. Signed-off-by: Daniel Fiala <danfiala23@gmail.com>

Motivation: - Reduce unnecessary complexity by introducing a flag-based implementation for `JsonWireFormat`. Changes: - Simplified `JsonWireFormat` by replacing boolean fields with a compact flag-based system. - Added caching for `JsonWireFormat` to improve memory efficiency. - Introduced a `mediaType` method to both `JsonWireFormat` and `ProtobufWireFormat` for determining content type dynamically. - Updated all components to use the new media type method for content type handling. - Replaced hardcoded wire format comparisons with reusable `mediaType`. Signed-off-by: Daniel Fiala <danfiala23@gmail.com>

…nto single classes. Motivation: - Simplify the codebase by eliminating separate `Impl` classes that provide no additional value. - Improve clarity by making `ProtobufJsonReader` and `ProtobufJsonWriter` self-contained. Changes: - Merged `ProtobufJsonReaderImpl` into `ProtobufJsonReader`. - Merged `ProtobufJsonWriterImpl` into `ProtobufJsonWriter`. - Updated constructors to handle `JsonWireFormat` directly within unified classes. - Removed redundant `Impl` classes and adjusted usage across the codebase.

zZHorizonZz requested a review from vietj May 4, 2026 06:11

zZHorizonZz force-pushed the wire-format-class branch from a42d0e6 to c1f0e5f Compare May 4, 2026 06:11

zZHorizonZz force-pushed the wire-format-class branch from c1f0e5f to efc804b Compare May 4, 2026 06:38

vietj reviewed May 4, 2026

View reviewed changes

Comment thread vertx-grpc-common/src/main/java/io/vertx/grpc/common/JsonWireFormat.java

zZHorizonZz force-pushed the wire-format-class branch 6 times, most recently from 6e15eab to 76d5171 Compare May 18, 2026 13:34

zZHorizonZz force-pushed the wire-format-class branch from 76d5171 to e3037e1 Compare June 2, 2026 18:41