Skip to content

Commit abda614

Browse files
committed
Order imports, remove logging
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
1 parent d0540c8 commit abda614

1 file changed

Lines changed: 11 additions & 32 deletions

File tree

vertx-pg-client/src/main/java/io/vertx/pgclient/impl/auth/scram/ScramSessionImpl.java

Lines changed: 11 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,6 @@
1717

1818
package io.vertx.pgclient.impl.auth.scram;
1919

20-
import java.nio.charset.StandardCharsets;
21-
import java.security.NoSuchAlgorithmException;
22-
import java.security.cert.Certificate;
23-
import java.security.cert.CertificateEncodingException;
24-
import java.security.cert.X509Certificate;
25-
import java.util.ArrayList;
26-
import java.util.List;
27-
28-
import javax.net.ssl.SSLException;
29-
import javax.net.ssl.SSLSession;
30-
3120
import com.ongres.scram.client.ChannelBindingException;
3221
import com.ongres.scram.client.ChannelBindingPolicy;
3322
import com.ongres.scram.client.ScramClient;
@@ -37,19 +26,24 @@
3726
import com.ongres.scram.common.exception.ScramRuntimeException;
3827
import com.ongres.scram.common.exception.ScramServerErrorException;
3928
import com.ongres.scram.common.util.TlsServerEndpoint;
40-
4129
import io.netty.buffer.ByteBuf;
4230
import io.netty.channel.ChannelHandlerContext;
4331
import io.netty.handler.ssl.SslHandler;
44-
import io.vertx.core.internal.logging.Logger;
45-
import io.vertx.core.internal.logging.LoggerFactory;
4632
import io.vertx.pgclient.ChannelBinding;
4733
import io.vertx.pgclient.impl.codec.ScramClientInitialMessage;
4834
import io.vertx.pgclient.impl.util.Util;
4935

50-
public class ScramSessionImpl implements ScramSession {
36+
import javax.net.ssl.SSLException;
37+
import javax.net.ssl.SSLSession;
38+
import java.nio.charset.StandardCharsets;
39+
import java.security.NoSuchAlgorithmException;
40+
import java.security.cert.Certificate;
41+
import java.security.cert.CertificateEncodingException;
42+
import java.security.cert.X509Certificate;
43+
import java.util.ArrayList;
44+
import java.util.List;
5145

52-
private static final Logger logger = LoggerFactory.getLogger(ScramSessionImpl.class);
46+
public class ScramSessionImpl implements ScramSession {
5347

5448
private final String username;
5549
private final char[] password;
@@ -77,8 +71,6 @@ public ScramClientInitialMessage createInitialSaslMessage(ByteBuf in, ChannelHan
7771
mechanisms.add(mechanism);
7872
}
7973

80-
logger.debug("Advertised SCRAM mechanisms: " + mechanisms);
81-
8274
this.scramClient = ScramClient.builder()
8375
.advertisedMechanisms(mechanisms)
8476
.username(username) // ignored by the server, use startup message
@@ -88,10 +80,7 @@ public ScramClientInitialMessage createInitialSaslMessage(ByteBuf in, ChannelHan
8880
.channelBinding(TlsServerEndpoint.TLS_SERVER_END_POINT, extractChannelBindingData(ctx))
8981
.build();
9082

91-
logger.debug("Selected SCRAM mechanism: " + scramClient.getScramMechanism().getName());
92-
9383
String clientFirstMessage = scramClient.clientFirstMessage().toString();
94-
logger.trace("SASLInitialResponse: " + clientFirstMessage);
9584

9685
return new ScramClientInitialMessage(clientFirstMessage,
9786
scramClient.getScramMechanism().getName());
@@ -105,18 +94,12 @@ public ScramClientInitialMessage createInitialSaslMessage(ByteBuf in, ChannelHan
10594
*/
10695
public String receiveServerFirstMessage(ByteBuf in) {
10796
String serverFirstMessage = in.readCharSequence(in.readableBytes(), StandardCharsets.UTF_8).toString();
108-
logger.trace("AuthenticationSASLContinue: " + serverFirstMessage);
109-
11097
try {
11198
scramClient.serverFirstMessage(serverFirstMessage);
11299
} catch (ScramParseException e) {
113100
throw new ScramRuntimeException(e.getMessage(), e);
114101
}
115-
116-
String clientFinalMessage = scramClient.clientFinalMessage().toString();
117-
logger.trace("SASLResponse: " + clientFinalMessage);
118-
119-
return clientFinalMessage;
102+
return scramClient.clientFinalMessage().toString();
120103
}
121104

122105
/*
@@ -129,8 +112,6 @@ public String receiveServerFirstMessage(ByteBuf in) {
129112
*/
130113
public void checkServerFinalMessage(ByteBuf in) {
131114
String serverFinalMessage = in.readCharSequence(in.readableBytes(), StandardCharsets.UTF_8).toString();
132-
logger.trace("AuthenticationSASLFinal: " + serverFinalMessage);
133-
134115
try {
135116
scramClient.serverFinalMessage(serverFinalMessage);
136117
} catch (ScramParseException | ScramServerErrorException | ScramInvalidServerSignatureException e) {
@@ -154,7 +135,6 @@ private byte[] extractChannelBindingData(ChannelHandlerContext ctx) {
154135
}
155136
}
156137
} catch (CertificateEncodingException | SSLException | NoSuchAlgorithmException e) {
157-
logger.debug("Error extracting channel binding data", e);
158138
if (channelBinding == ChannelBindingPolicy.REQUIRE) {
159139
throw new ChannelBindingException(e.getMessage());
160140
}
@@ -165,7 +145,6 @@ private byte[] extractChannelBindingData(ChannelHandlerContext ctx) {
165145
}
166146

167147
private static ChannelBindingPolicy getChannelBindingPolicy(ChannelBinding channelBinding) {
168-
logger.debug("ChannelBinding: " + channelBinding);
169148
switch (channelBinding) {
170149
case DISABLE:
171150
return ChannelBindingPolicy.DISABLE;

0 commit comments

Comments
 (0)