Skip to content

Commit ac5bef6

Browse files
committed
Fix MetricsTestBase
Begin/End metrics size depends on the timeout parameter value. When a timeout is expected, a single begin/end metric should be listed, corresponding to the getConnection/close calls wrapping the tasks. When a timeout isn't expected, the number of begin/end metric is the number of tasks plus one, corresponding to the getConnection/close calls. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
1 parent 2b303a6 commit ac5bef6

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

vertx-sql-client/src/test/java/io/vertx/tests/sqlclient/tck/MetricsTestBase.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,8 @@ public void end(Object usageMetric) {
177177
ctx.assertEquals(0, queueSize.get());
178178
ctx.assertEquals(enqueueMetrics, dequeueMetrics);
179179
ctx.assertEquals(0, usageSize.get());
180-
ctx.assertEquals(num, beginMetrics.size());
181-
ctx.assertEquals(num, endMetrics.size());
180+
ctx.assertEquals(timeout ? 1 : num + 1, beginMetrics.size());
181+
ctx.assertEquals(timeout ? 1 : num + 1, endMetrics.size());
182182
ctx.assertEquals(beginMetrics, endMetrics);
183183
ctx.assertEquals("sql", poolType);
184184
ctx.assertEquals("the-pool", poolName);

0 commit comments

Comments
 (0)