Skip to content

Commit dca622d

Browse files
committed
Skip TIME overflow tests for MySQL 9.6
Starting with MySQL 9.5, overflow is reported as an error Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
1 parent eeb56e2 commit dca622d

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

vertx-mysql-client/src/test/java/io/vertx/tests/mysqlclient/data/DateTimeBinaryCodecTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
import java.time.LocalTime;
2727
import java.util.function.Consumer;
2828

29+
import static org.junit.Assume.assumeTrue;
30+
2931
@RunWith(VertxUnitRunner.class)
3032
public class DateTimeBinaryCodecTest extends DateTimeCodecTest {
3133
@Test
@@ -63,11 +65,15 @@ public void testEncodeMinTime(TestContext ctx) {
6365

6466
@Test
6567
public void testEncodeMaxTimeOverflow(TestContext ctx) {
68+
// Starting with MySQL 9.5, overflow is reported as an error
69+
assumeTrue(rule.isUsingMariaDB() || rule.isUsingMySQL8());
6670
testEncodeTime(ctx, Duration.ofDays(120).plusHours(19).plusMinutes(27).plusSeconds(30), Duration.ofHours(838).plusMinutes(59).plusSeconds(59));
6771
}
6872

6973
@Test
7074
public void testEncodeMinTimeOverflow(TestContext ctx) {
75+
// Starting with MySQL 9.5, overflow is reported as an error
76+
assumeTrue(rule.isUsingMariaDB() || rule.isUsingMySQL8());
7177
testEncodeTime(ctx, Duration.ofDays(-120).plusHours(-19).plusMinutes(-27).plusSeconds(-30), Duration.ofHours(-838).plusMinutes(-59).plusSeconds(-59));
7278
}
7379

vertx-mysql-client/src/test/java/io/vertx/tests/mysqlclient/junit/MySQLRule.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,10 @@ public boolean isUsingMariaDB() {
162162
return databaseServerInfo.getDatabaseType() == DatabaseType.MariaDB;
163163
}
164164

165+
public boolean isUsingMySQL8() {
166+
return databaseServerInfo == DatabaseServerInfo.MySQL_V8_4;
167+
}
168+
165169
public MySQLConnectOptions options() {
166170
return new MySQLConnectOptions(options);
167171
}

0 commit comments

Comments
 (0)