Bug: PgDriver.createConnectionFactory ignores NetClientOptions parameter

[YunlongJ]

Version

5.0.7

Context

In io.vertx.pgclient.spi.PgDriver, the createConnectionFactory method implementation ignores the transportOptions argument. This means any NetClientOptions passed during pool creation or factory initialization are not applied to the underlying PgConnectionFactory.

Code Snippet

https://github.com/eclipse-vertx/vertx-sql-client/blob/master/vertx-pg-client/src/main/java/io/vertx/pgclient/spi/PgDriver.java

@Override
public ConnectionFactory<PgConnectOptions> createConnectionFactory(Vertx vertx, NetClientOptions transportOptions) {
  // transportOptions is ignored here!
  return new PgConnectionFactory((VertxInternal) vertx);
}

Steps to reproduce

1. Create a PgPool with specific NetClientOptions (e.g., socks5 proxy).
2. The PgDriver will instantiate PgConnectionFactory using only the Vertx instance.
3. The custom NetClientOptions are discarded.

Do you have a reproducer?

No response

[doxlik]

@vietj @tsegismont could you please take a look when you have time?

From what I can see, the only factory that actually uses the passed NetClientOptions is DB2ConnectionFactory:

public DB2ConnectionFactory(VertxInternal vertx, NetClientOptions tcpOptions) {
  super(vertx, tcpOptions);
}

The other factories seem to ignore these options.

Is this intentional, or should they also propagate the options?

[tsegismont]

@doxlik which option are you missing from NetClientOptions ?

I believe this has changed while @vietj was working on driver refactoring, perhaps we've missed that problem. I would say this is a bug since the client builder lets users configure the options in io.vertx.sqlclient.ClientBuilder#with(io.vertx.core.net.NetClientOptions)

@vietj was this change intentional? In this case why?

Otherwise, we'll fix the issue in the next release

[doxlik]

@tsegismont hi, thank you for the detailed answer.

Regarding your question about which option might be missing: the issue author @YunlongJ mentioned a SOCKS5 proxy as an example. In my case, it would mainly be useful to have access to TCP-level options (for example tcpNoDelay).

At the same time, I noticed the following in the implementation:

    this.client = vertx.createNetClient(new NetClientOptions(tcpOptions).setReconnectAttempts(0)); // auto-retry is handled on the protocol level instead of network level

This suggests that some behavior is intentionally controlled at the driver level rather than purely delegated to the TCP client, which makes sense.

However, if the supplied NetClientOptions were propagated directly, some options like idleTimeout might have unintended effects. For example, if there is no traffic for some time, the underlying TCP connection could be closed even though the driver still considers the database connection alive.

So perhaps this could be one of the reasons for not applying the options directly, or maybe certain properties should be overridden by the driver.

[tsegismont]

I discussed this with @vietj off-list, it seems it's a bug introduced when refactoring the driver/connection factory classes. I'll take care of it

[tsegismont]

Fixed by #1631