Improve eager command failure in PostgreSQL client#1507
Merged
Conversation
…ge through the Netty pipeline. This raise issues when there is a read in progress with reentrancy, while this issue should be also addressed in vertx core, proceeding this way means caring about the channel read/readComplete status to eventually emit a readComplete to respect the Netty inbound message protocol. Instead we can simply fail the handler associated with the codec yielding the same result.
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Mar 28, 2025
Follows up on onhttps://github.com/eclipse-vertx/pull/1507 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Mar 28, 2025
Follows up on onhttps://github.com//pull/1507 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PgCodectries to fail a command in progress by firing a failure message through the Netty pipeline. This raise issues when there is a read in progress with reentrancy, while this issue should be also addressed in vertx core, proceeding this way means caring about the channelread/readCompletestatus to eventually emit areadCompleteto respect the Netty inbound message protocol.Instead we can simply fail the handler associated with the codec yielding the same result.