From f96344c67958259dabd8919ab1bf6082705c63bd Mon Sep 17 00:00:00 2001 From: Thomas Segismont Date: Tue, 21 Oct 2025 18:06:51 +0200 Subject: [PATCH] Refactor PreparedStatementTestBase.testInferDataType42P18 For clarity, separated the tests into two independent checks, that use their own connection. Signed-off-by: Thomas Segismont --- .../pgclient/PreparedStatementTestBase.java | 29 ++++++++++--------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/vertx-pg-client/src/test/java/io/vertx/tests/pgclient/PreparedStatementTestBase.java b/vertx-pg-client/src/test/java/io/vertx/tests/pgclient/PreparedStatementTestBase.java index 0f20dc709..a7291df1f 100644 --- a/vertx-pg-client/src/test/java/io/vertx/tests/pgclient/PreparedStatementTestBase.java +++ b/vertx-pg-client/src/test/java/io/vertx/tests/pgclient/PreparedStatementTestBase.java @@ -527,24 +527,25 @@ private void testInferDataType42P18(TestContext ctx, Class type, T value, } private void testInferDataType42P18(TestContext ctx, Class type, T value, String suffix1, String suffix2) { + PgConnection.connect(vertx, options()).onComplete(ctx.asyncAssertSuccess(conn -> { + conn + .preparedQuery("SELECT CONCAT('HELLO ', $1)").execute(Tuple.of(value)) + .map(rows -> rows.iterator().next().getString(0)) + .eventually(() -> conn.close()) + .onComplete(ctx.asyncAssertSuccess(str -> { + ctx.assertEquals("HELLO " + suffix1, str); + })); + })); Object array = Array.newInstance(type, 1); Array.set(array, 0, value); PgConnection.connect(vertx, options()).onComplete(ctx.asyncAssertSuccess(conn -> { conn - .preparedQuery("SELECT CONCAT('HELLO ', $1)").execute(Tuple.of(value)) - .map(result1 -> { - Row row1 = result1.iterator().next(); - ctx.assertEquals("HELLO " + suffix1, row1.getString(0)); - return ""; - }) - .compose(v -> conn.preparedQuery("SELECT CONCAT('HELLO ', $1)").execute(Tuple.of(array))) - .map(result2 -> { - Row row2 = result2.iterator().next(); - String v = row2.getString(0); - ctx.assertEquals("HELLO " + suffix2, row2.getString(0)); - return ""; - }) - .eventually(() -> conn.close()); + .preparedQuery("SELECT CONCAT('HELLO ', $1)").execute(Tuple.of(array)) + .map(rows -> rows.iterator().next().getString(0)) + .eventually(() -> conn.close()) + .onComplete(ctx.asyncAssertSuccess(str -> { + ctx.assertEquals("HELLO " + suffix2, str); + })); })); }