Make sure to handle microsecond resolution as PostgreSQL does#1575
Merged
Conversation
Fixes eclipse-vertx#1165 PostgreSQL has microsecond resolution for timestamps. When converting from text, if the nanoseconds part after microseconds is strictly bigger than 499, PostgreSQL server rounds up to the next microsecond. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Member
Author
|
@DavideD would you mind to have a look? I think it should be fine for Hibernate Reactive but better safe than sorry :-) |
Contributor
|
ACK. |
Use the timestamp min/max values from PostgreSQL server Then, it's safe to add microseconds to the computed timestamps because we're well under the limit of LocalDateTime.MAX Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1165
PostgreSQL has microsecond resolution for timestamps. When converting from text, if the nanoseconds part after microseconds is strictly bigger than 499, PostgreSQL server rounds up to the next microsecond.