Expose RowDescriptor in Cursor and RowStream#1577
Merged
Merged
Conversation
Closes eclipse-vertx#1341 The value is null until the first set of rows is fetched from the database. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Fetch command not supported Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
force-pushed
the
issue/1341
branch
from
fc9adcc to
b65c5a3
Compare
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Nov 21, 2025
Follows-up on eclipse-vertx#1577 The endHandler was no longer captured safely after changes in the previous PR. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Nov 21, 2025
Follows-up on eclipse-vertx#1577 The endHandler was no longer captured safely after changes in the previous PR. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Nov 21, 2025
* Capture RowStreamImpl endHandler in a synchronized block Follows-up on #1577 The endHandler was no longer captured safely after changes in the previous PR. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * RowStream handler should be invoked out the synchronized block It's safer not to hold a lock on the stream instance while invoking user code. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1341
The value is null until the first set of rows is fetched from the database.