Skip to content

Split CI workflow to prevent schedule inactivity from pausing push/PR builds#1629

Merged
tsegismont merged 2 commits intoeclipse-vertx:masterfrom
tsegismont:workflow-schedule-split
Mar 6, 2026
Merged

Split CI workflow to prevent schedule inactivity from pausing push/PR builds#1629
tsegismont merged 2 commits intoeclipse-vertx:masterfrom
tsegismont:workflow-schedule-split

Conversation

@tsegismont
Copy link
Copy Markdown
Member

@tsegismont tsegismont requested a review from vietj March 5, 2026 09:37
@vietj
Copy link
Copy Markdown
Member

vietj commented Mar 5, 2026

does this require only a commit in master branch, or does it also require commits to other branches ?

Comment thread .github/workflows/schedule-5.x-stable.yml Outdated
@vietj
Copy link
Copy Markdown
Member

vietj commented Mar 5, 2026

I am wondering also if in that case we could not have a single ci-5.x.yml file and get rid of ci-5.x-stable.yml

in the master branch, the only purpose of ci-5.x-stable.yml is to continue pull requests CI builds when we will create a new 5.x branch

Comment thread .github/workflows/ci-5.x-stable.yml Outdated
@tsegismont
Copy link
Copy Markdown
Member Author

does this require only a commit in master branch, or does it also require commits to other branches ?

Just in master, that's where our scheduled workflows are https://github.com/eclipse-vertx/vertx-sql-client/actions?query=event%3Aschedule

@tsegismont
Copy link
Copy Markdown
Member Author

tsegismont commented Mar 5, 2026

I am wondering also if in that case we could not have a single ci-5.x.yml file and get rid of ci-5.x-stable.yml

That should be possible, indeed. Would you like me to give it a try here?

… builds

See vert-x3/issues#665

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont force-pushed the workflow-schedule-split branch from 9b64b54 to 6337d1c Compare March 5, 2026 13:51
@vietj
Copy link
Copy Markdown
Member

vietj commented Mar 5, 2026

I am wondering also if in that case we could not have a single ci-5.x.yml file and get rid of ci-5.x-stable.yml

That should be possible, indeed. Would you like me to give it a try here?

yes

did you test this change on a fork of this repo to ensure it works as expected for other branches ?

@tsegismont
Copy link
Copy Markdown
Member Author

did you test this change on a fork of this repo to ensure it works as expected for other branches ?

Not sure what you mean exactly, can you elaborate?

For CI builds triggered by pushes to supported branches or pull requests, we can have a single file that lists the branches.

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont force-pushed the workflow-schedule-split branch from 80858ac to 4b3b786 Compare March 5, 2026 16:09
@tsegismont
Copy link
Copy Markdown
Member Author

That should be possible, indeed. Would you like me to give it a try here?

yes

Just pushed a commit for this. But we need to backport the change to 5.0. Otherwise, GH will use the workflow definition that is present in this branch.

@tsegismont
Copy link
Copy Markdown
Member Author

As discussed off-list, there's no need to backport this. I'll go ahead and merge. Let's see how it goes and, if it works well, we can generalize the change through the stack.

@tsegismont tsegismont merged commit 900cc1f into eclipse-vertx:master Mar 6, 2026
18 checks passed
@tsegismont tsegismont deleted the workflow-schedule-split branch March 6, 2026 15:11
tsegismont added a commit to tsegismont/vertx-sql-client that referenced this pull request Mar 24, 2026
tsegismont added a commit that referenced this pull request Mar 24, 2026
* Revert "Rename scheduled jobs (#1637)"

This reverts commit 3fe39b4.

* Revert "Split CI workflow to prevent schedule inactivity from pausing push/PR builds (#1629)"

This reverts commit 900cc1f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants