Move database version profiles to individual client POMs#1640
Merged
tsegismont merged 6 commits intoeclipse-vertx:masterfrom Mar 30, 2026
Merged
Move database version profiles to individual client POMs#1640tsegismont merged 6 commits intoeclipse-vertx:masterfrom
tsegismont merged 6 commits intoeclipse-vertx:masterfrom
Conversation
Relocate database-specific testing profiles from root pom.xml to individual client modules. CI now uses Maven's -pl/-am flags for targeted builds instead of profile-based module selection. This commit decentralizes the Maven profile configuration, moving it from a monolithic root POM to the individual database client modules. Some portions of this content were created with the assistance of Claude Code. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
force-pushed
the
fix-ci-configs
branch
from
8abaf87 to
5ace9f8
Compare
tsegismont
changed the title
Otherwise, we don't get information about a particular database type Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
MySQL 5.6 only supports TLS 1.0/1.1 which are disabled in Java 11+ Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
PostgreSQL 9 cannot infer types from NULL for BigDecimal, temporal types (LocalTime, OffsetTime, Temporal), and their array variants. Override these test methods to skip on PostgreSQL 9 using assumeTrue checks. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Member
Author
|
@vietj it seems all the issues are solved now 😌 When we get a green build, I'll merge the PR and backport to supported branches |
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Mar 30, 2026
…tx#1640) * Move database version profiles to individual client POMs Relocate database-specific testing profiles from root pom.xml to individual client modules. CI now uses Maven's -pl/-am flags for targeted builds instead of profile-based module selection. This commit decentralizes the Maven profile configuration, moving it from a monolithic root POM to the individual database client modules. Some portions of this content were created with the assistance of Claude Code. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Disable fail-fast in CI matrix Otherwise, we don't get information about a particular database type Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Skip MySQLTLSTest when testing MySQL 5.6 MySQL 5.6 only supports TLS 1.0/1.1 which are disabled in Java 11+ Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Make MSSQLRule work with all tested MSSQL versions Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Skip PostgreSQL 9 NULL type inference tests PostgreSQL 9 cannot infer types from NULL for BigDecimal, temporal types (LocalTime, OffsetTime, Temporal), and their array variants. Override these test methods to skip on PostgreSQL 9 using assumeTrue checks. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Removed empty profiles block Signed-off-by: Thomas Segismont <tsegismont@gmail.com> --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Mar 30, 2026
* Move database version profiles to individual client POMs Relocate database-specific testing profiles from root pom.xml to individual client modules. CI now uses Maven's -pl/-am flags for targeted builds instead of profile-based module selection. This commit decentralizes the Maven profile configuration, moving it from a monolithic root POM to the individual database client modules. Some portions of this content were created with the assistance of Claude Code. * Disable fail-fast in CI matrix Otherwise, we don't get information about a particular database type * Skip MySQLTLSTest when testing MySQL 5.6 MySQL 5.6 only supports TLS 1.0/1.1 which are disabled in Java 11+ * Make MSSQLRule work with all tested MSSQL versions * Skip PostgreSQL 9 NULL type inference tests PostgreSQL 9 cannot infer types from NULL for BigDecimal, temporal types (LocalTime, OffsetTime, Temporal), and their array variants. Override these test methods to skip on PostgreSQL 9 using assumeTrue checks. * Removed empty profiles block --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Mar 30, 2026
…tx#1640) * Move database version profiles to individual client POMs Relocate database-specific testing profiles from root pom.xml to individual client modules. CI now uses Maven's -pl/-am flags for targeted builds instead of profile-based module selection. This commit decentralizes the Maven profile configuration, moving it from a monolithic root POM to the individual database client modules. Some portions of this content were created with the assistance of Claude Code. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Disable fail-fast in CI matrix Otherwise, we don't get information about a particular database type Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Skip MySQLTLSTest when testing MySQL 5.6 MySQL 5.6 only supports TLS 1.0/1.1 which are disabled in Java 11+ Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Make MSSQLRule work with all tested MSSQL versions Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Skip PostgreSQL 9 NULL type inference tests PostgreSQL 9 cannot infer types from NULL for BigDecimal, temporal types (LocalTime, OffsetTime, Temporal), and their array variants. Override these test methods to skip on PostgreSQL 9 using assumeTrue checks. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Removed empty profiles block Signed-off-by: Thomas Segismont <tsegismont@gmail.com> --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Mar 30, 2026
* Move database version profiles to individual client POMs Relocate database-specific testing profiles from root pom.xml to individual client modules. CI now uses Maven's -pl/-am flags for targeted builds instead of profile-based module selection. This commit decentralizes the Maven profile configuration, moving it from a monolithic root POM to the individual database client modules. Some portions of this content were created with the assistance of Claude Code. * Disable fail-fast in CI matrix Otherwise, we don't get information about a particular database type * Skip MySQLTLSTest when testing MySQL 5.6 MySQL 5.6 only supports TLS 1.0/1.1 which are disabled in Java 11+ * Make MSSQLRule work with all tested MSSQL versions * Skip PostgreSQL 9 NULL type inference tests PostgreSQL 9 cannot infer types from NULL for BigDecimal, temporal types (LocalTime, OffsetTime, Temporal), and their array variants. Override these test methods to skip on PostgreSQL 9 using assumeTrue checks. * Removed empty profiles block --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relocate database-specific testing profiles from root pom.xml to individual client modules.
CI now uses Maven's -pl/-am flags for targeted builds instead of profile-based module selection.
This commit decentralizes the Maven profile configuration, moving it from a monolithic root POM to the individual database client modules.
Some portions of this content were created with the assistance of Claude Code.