Speed up PostgreSQL builds#1649
Merged
tsegismont merged 1 commit intoeclipse-vertx:masterfrom Apr 1, 2026
Merged
Conversation
Create a shared rule instance in ContainerPgRule. This instance is used where we don't need particular customization (SSL, different user, ...etc.). In ContainerPgRule#after method, we skip stopping the server if the method is called on the SHARED instance. Therefore, we avoid starting/stopping the PostgreSQL container before/after each test class. On my box, the builds takes 1-2 minutes instead of 5-6 minutes. This behavior is aligned with MySQL, MSSQL and Oracle clients testing. Also, modified EnumeratedTypesExtendedCodecTest#testEncodeEnumArrayEmptyValues. It checked a column that had nothing to do with enum array. Without this change, we cannot use a shared rule. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Apr 1, 2026
Create a shared rule instance in ContainerPgRule. This instance is used where we don't need particular customization (SSL, different user, ...etc.). In ContainerPgRule#after method, we skip stopping the server if the method is called on the SHARED instance. Therefore, we avoid starting/stopping the PostgreSQL container before/after each test class. On my box, the builds takes 1-2 minutes instead of 5-6 minutes. This behavior is aligned with MySQL, MSSQL and Oracle clients testing. Also, modified EnumeratedTypesExtendedCodecTest#testEncodeEnumArrayEmptyValues. It checked a column that had nothing to do with enum array. Without this change, we cannot use a shared rule. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Apr 1, 2026
Backport of eclipse-vertx#1649 Create a shared rule instance in ContainerPgRule. This instance is used where we don't need particular customization (SSL, different user, ...etc.). In ContainerPgRule#after method, we skip stopping the server if the method is called on the SHARED instance. Therefore, we avoid starting/stopping the PostgreSQL container before/after each test class. On my box, the builds takes 1-2 minutes instead of 5-6 minutes. This behavior is aligned with MySQL, MSSQL and Oracle clients testing. Also, modified EnumeratedTypesExtendedCodecTest#testEncodeEnumArrayEmptyValues. It checked a column that had nothing to do with enum array. Without this change, we cannot use a shared rule. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Apr 1, 2026
Backport of #1649 Create a shared rule instance in ContainerPgRule. This instance is used where we don't need particular customization (SSL, different user, ...etc.). In ContainerPgRule#after method, we skip stopping the server if the method is called on the SHARED instance. Therefore, we avoid starting/stopping the PostgreSQL container before/after each test class. On my box, the builds takes 1-2 minutes instead of 5-6 minutes. This behavior is aligned with MySQL, MSSQL and Oracle clients testing. Also, modified EnumeratedTypesExtendedCodecTest#testEncodeEnumArrayEmptyValues. It checked a column that had nothing to do with enum array. Without this change, we cannot use a shared rule. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a shared rule instance in ContainerPgRule.
This instance is used where we don't need particular customization (SSL, different user, ...etc.). In ContainerPgRule#after method, we skip stopping the server if the method is called on the SHARED instance. Therefore, we avoid starting/stopping the PostgreSQL container before/after each test class. On my box, the builds takes 1-2 minutes instead of 5-6 minutes. This behavior is aligned with MySQL, MSSQL and Oracle clients testing.
Also, modified EnumeratedTypesExtendedCodecTest#testEncodeEnumArrayEmptyValues. It checked a column that had nothing to do with enum array. Without this change, we cannot use a shared rule.