Improve pgbouncer test#1651
Merged
tsegismont merged 3 commits intoeclipse-vertx:masterfrom Apr 1, 2026
Merged
Conversation
Member
tsegismont
commented
Apr 1, 2026
tsegismont
commented
- Reuse pgBouncer image across builds
- Increase PgBouncerTest timeout to 5 minutes
- Manage connections properly in PgBouncerTest
This will speed up the test when running the test suite locally Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
The test fails intermittently like this on CI: 2026-02-09T10:53:31.9241881Z [ERROR] io.vertx.pgclient.PgBouncerTest.testPreparedBatch -- Time elapsed: 132.0 s <<< ERROR! 2026-02-09T10:53:31.9243012Z java.util.concurrent.TimeoutException 2026-02-09T10:53:31.9243800Z at io.vertx.ext.unit.impl.TestContextImpl.lambda$run$1(TestContextImpl.java:79) 2026-02-09T10:53:31.9244627Z at java.base/java.lang.Thread.run(Thread.java:1474) So let's give it a chance to complete in case the build of the container image and the startup take too long. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Setup connections before each test in setUp method. Close them after each test in tearDown method. Also, use Vert.x Future#await methods for readability. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Apr 1, 2026
* Reuse pgBouncer image across builds This will speed up the test when running the test suite locally Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Increase PgBouncerTest timeout to 5 minutes The test fails intermittently like this on CI: 2026-02-09T10:53:31.9241881Z [ERROR] io.vertx.pgclient.PgBouncerTest.testPreparedBatch -- Time elapsed: 132.0 s <<< ERROR! 2026-02-09T10:53:31.9243012Z java.util.concurrent.TimeoutException 2026-02-09T10:53:31.9243800Z at io.vertx.ext.unit.impl.TestContextImpl.lambda$run$1(TestContextImpl.java:79) 2026-02-09T10:53:31.9244627Z at java.base/java.lang.Thread.run(Thread.java:1474) So let's give it a chance to complete in case the build of the container image and the startup take too long. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Manage connections properly in PgBouncerTest Setup connections before each test in setUp method. Close them after each test in tearDown method. Also, use Vert.x Future#await methods for readability. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Apr 1, 2026
* Reuse pgBouncer image across builds This will speed up the test when running the test suite locally Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Increase PgBouncerTest timeout to 5 minutes The test fails intermittently like this on CI: 2026-02-09T10:53:31.9241881Z [ERROR] io.vertx.pgclient.PgBouncerTest.testPreparedBatch -- Time elapsed: 132.0 s <<< ERROR! 2026-02-09T10:53:31.9243012Z java.util.concurrent.TimeoutException 2026-02-09T10:53:31.9243800Z at io.vertx.ext.unit.impl.TestContextImpl.lambda$run$1(TestContextImpl.java:79) 2026-02-09T10:53:31.9244627Z at java.base/java.lang.Thread.run(Thread.java:1474) So let's give it a chance to complete in case the build of the container image and the startup take too long. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Manage connections properly in PgBouncerTest Setup connections before each test in setUp method. Close them after each test in tearDown method. Also, use Vert.x Future#await methods for readability. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.