Fix PreparedStatementTestBase#XXXX42P18 intermittent failures#1654
Merged
tsegismont merged 1 commit intoeclipse-vertx:masterfrom Apr 2, 2026
Merged
Conversation
Changed implementation for the in-transaction case. There was a racy behavior between the closing of the connection close and the invocation of the assertion. Changed the implementation to close the connection after verifying expectations. Repeating test to make it more likely to fail on CI if there's still a problem. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Apr 2, 2026
Changed implementation for the in-transaction case. There was a racy behavior between the closing of the connection close and the invocation of the assertion. Changed the implementation to close the connection after verifying expectations. Repeating test to make it more likely to fail on CI if there's still a problem. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Apr 2, 2026
Changed implementation for the in-transaction case. There was a racy behavior between the closing of the connection close and the invocation of the assertion. Changed the implementation to close the connection after verifying expectations. Repeating test to make it more likely to fail on CI if there's still a problem. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed implementation for the in-transaction case.
There was a racy behavior between the closing of the connection close and the invocation of the assertion.
Changed the implementation to close the connection after verifying expectations.
Repeating test to make it more likely to fail on CI if there's still a problem.