Skip to content

Add Astro web framework support#1858

Merged
vrubezhny merged 1 commit into
eclipse-wildwebdeveloper:masterfrom
sebthom:astro
Jun 24, 2025
Merged

Add Astro web framework support#1858
vrubezhny merged 1 commit into
eclipse-wildwebdeveloper:masterfrom
sebthom:astro

Conversation

@sebthom

@sebthom sebthom commented May 29, 2025

Copy link
Copy Markdown
Member

This PR integrates the Astro language server into WildWebDeveloper and enables syntax highlighting of *.astro files via TM4E.

image

Why to add Astro support?

Core Web Vitals - Technology Report:

image

GitHub Star History:

image

@sebthom

sebthom commented May 29, 2025

Copy link
Copy Markdown
Member Author

@vrubezhny can you please request a license review?

@akurtakov

Copy link
Copy Markdown
Contributor

/request-license-review

@github-actions

Copy link
Copy Markdown

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-wildwebdeveloper/wildwebdeveloper/actions/runs/15323642208

@akurtakov

akurtakov commented May 29, 2025

Copy link
Copy Markdown
Contributor

@vrubezhny

Copy link
Copy Markdown
Contributor

We also should probably request the IP Team Review for grammars and language config. But why not to contribute them to tm4e first? (Have anyone checked the existence of astro-grammars in tm4e?)

@sebthom

sebthom commented May 29, 2025

Copy link
Copy Markdown
Member Author

@vrubezhny In TM4E we only include all the syntax files built into vscode https://github.com/microsoft/vscode/tree/main/extensions and I would like to keep it like that.

@vrubezhny

vrubezhny commented May 29, 2025

Copy link
Copy Markdown
Contributor

@sebthom do you know a source/project/repo these astro grammars were taken from?

Found in README.md

@vrubezhny

vrubezhny commented May 29, 2025

Copy link
Copy Markdown
Contributor

An IP Team Review request for astro grammars:

... but probably it'd be much easier just adding astro-vscode@2.15.4 as a dependency.

@sebthom

sebthom commented May 29, 2025

Copy link
Copy Markdown
Member Author

@vrubezhny regarding the IP review it is surely better to depend on astro-vscode. I'll check if it makes sense to adjust the PR

@sebthom

sebthom commented May 29, 2025

Copy link
Copy Markdown
Member Author

@vrubezhny I changed the PR to depend on astro-vscode@2.15.4 which also pulls in the grammar files. Nice side effect is that the node_modules occupies ca. 10MB less than when using @astro/language-server

@akurtakov could you please request another license review?

@akurtakov

Copy link
Copy Markdown
Contributor

/request-license-review

@github-actions

Copy link
Copy Markdown

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-wildwebdeveloper/wildwebdeveloper/actions/runs/15340478123

@akurtakov

Copy link
Copy Markdown
Contributor

@sebthom

sebthom commented Jun 23, 2025

Copy link
Copy Markdown
Member Author

It looks like all IP requests are approved, no?

@vrubezhny

Copy link
Copy Markdown
Contributor

/request-license-review

@github-actions

Copy link
Copy Markdown

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-wildwebdeveloper/wildwebdeveloper/actions/runs/15833829677

@vrubezhny

vrubezhny commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

Yet another IP Team Review request is created for a transitive dependency:

@vrubezhny vrubezhny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@vrubezhny vrubezhny merged commit 49b186a into eclipse-wildwebdeveloper:master Jun 24, 2025
8 of 10 checks passed
@sebthom sebthom deleted the astro branch November 9, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants