Skip to content

Commit f427e2e

Browse files
committed
fix(session): remove timestamp_instrumentation from declare_publisher
PublisherBuilder has no timestamp_instrumentation setter. Pass it per-put via publisher.put(timestamp_instrumentation=...) instead.
1 parent 239d3e1 commit f427e2e

2 files changed

Lines changed: 2 additions & 7 deletions

File tree

src/session.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ impl Session {
243243
}
244244

245245
#[allow(clippy::too_many_arguments)]
246-
#[pyo3(signature = (key_expr, *, encoding = None, congestion_control = None, priority = None, express = None, reliability = None, allowed_destination = None, timestamp_instrumentation = None))]
246+
#[pyo3(signature = (key_expr, *, encoding = None, congestion_control = None, priority = None, express = None, reliability = None, allowed_destination = None))]
247247
fn declare_publisher(
248248
&self,
249249
py: Python,
@@ -254,9 +254,8 @@ impl Session {
254254
express: Option<bool>,
255255
reliability: Option<Reliability>,
256256
allowed_destination: Option<Locality>,
257-
timestamp_instrumentation: Option<TimestampInstrumentation>,
258257
) -> PyResult<Publisher> {
259-
let mut builder = build!(
258+
let builder = build!(
260259
self.0.declare_publisher(key_expr),
261260
encoding,
262261
congestion_control,
@@ -265,9 +264,6 @@ impl Session {
265264
reliability,
266265
allowed_destination,
267266
);
268-
if let Some(instr) = timestamp_instrumentation {
269-
builder = builder.timestamp_instrumentation(Some(instr.0));
270-
}
271267
wait(py, builder).map_into()
272268
}
273269

zenoh/__init__.pyi

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1616,7 +1616,6 @@ class Session:
16161616
express: bool | None = None,
16171617
reliability: Reliability | None = None,
16181618
allowed_destination: Locality | None = None,
1619-
timestamp_instrumentation: TimestampInstrumentation | None = None,
16201619
) -> Publisher:
16211620
"""Create a :class:`Publisher` for the given key expression."""
16221621

0 commit comments

Comments
 (0)