Skip to content

add CongestionControl.BLOCK_FIRST#553

Merged
OlivierHecart merged 4 commits into
eclipse-zenoh:mainfrom
ZettaScaleLabs:cc-block-first
Jul 23, 2025
Merged

add CongestionControl.BLOCK_FIRST#553
OlivierHecart merged 4 commits into
eclipse-zenoh:mainfrom
ZettaScaleLabs:cc-block-first

Conversation

@wyfo
Copy link
Copy Markdown
Contributor

@wyfo wyfo commented Jul 17, 2025

No description provided.

@wyfo wyfo requested a review from milyin July 17, 2025 08:07
@github-actions
Copy link
Copy Markdown
Contributor

PR missing one of the required labels: {'enhancement', 'internal', 'new feature', 'bug', 'documentation', 'breaking-change', 'dependencies'}

@github-actions
Copy link
Copy Markdown
Contributor

PR missing one of the required labels: {'enhancement', 'new feature', 'internal', 'documentation', 'dependencies', 'breaking-change', 'bug'}

@github-actions
Copy link
Copy Markdown
Contributor

PR missing one of the required labels: {'internal', 'bug', 'new feature', 'documentation', 'enhancement', 'dependencies', 'breaking-change'}

@wyfo wyfo added the new feature Something new is needed label Jul 17, 2025
@wyfo wyfo requested a review from OlivierHecart July 17, 2025 10:05
Comment thread zenoh/__init__.pyi

DROP = auto()
BLOCK = auto()
BLOCK_FIRST = _unstable(auto())
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any way to handle this _unstable in docs generation ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so

Comment thread src/qos.rs Outdated
enum_mapper!(zenoh::qos::CongestionControl: u8 {
Drop = 0,
Block = 1,
BlockFirst = 2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma please

@OlivierHecart OlivierHecart merged commit 3e82477 into eclipse-zenoh:main Jul 23, 2025
12 checks passed
@OlivierHecart OlivierHecart deleted the cc-block-first branch July 23, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Something new is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants