Skip to content

[ZEN-587] Change replier_id type to EntityGlobalId #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sashacmc merged 5 commits into from
Jul 24, 2025
Merged

[ZEN-587] Change replier_id type to EntityGlobalId #554

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0bff31c
Change replier_id type to EntityGlobalId
oteffahi Jul 22, 2025
277c844
Sync lockfile
oteffahi Jul 24, 2025
1b97755
Merge branch 'main' into api/make-replier-id-global
oteffahi Jul 24, 2025
c4a0845
Fix lockfile version
oteffahi Jul 24, 2025
de86687
Merge branch 'main' into api/make-replier-id-global
oteffahi Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ use pyo3::{

use crate::{
bytes::{Encoding, ZBytes},
config::ZenohId,
handlers::{into_handler, HandlerImpl},
key_expr::KeyExpr,
macros::{build, downcast_or_new, enum_mapper, option_wrapper, wrapper},
qos::{CongestionControl, Priority},
session::EntityGlobalId,
utils::{generic, wait, IntoPyResult, IntoPython, IntoRust, MapInto},
};

Expand Down Expand Up @@ -223,7 +223,7 @@ impl Reply {
}

#[getter]
fn replier_id(&self) -> Option<ZenohId> {
fn replier_id(&self) -> Option<EntityGlobalId> {
self.0.replier_id().map_into()
}

Expand Down
2 changes: 1 addition & 1 deletion zenoh/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ class Reply:
def err(self) -> ReplyError | None: ...
@property
@_unstable
def replier_id(self) -> ZenohId | None: ...
def replier_id(self) -> EntityGlobalId | None: ...

@final
class ReplyError:
Expand Down
Loading