Skip to content

Commit a3414f0

Browse files
committed
fix review comments
1 parent 7e3f68e commit a3414f0

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/core/src/util/errors.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import isEqual from 'lodash/isEqual';
3232

3333
/**
3434
* Checks for an additionally specified property that the error relates to.
35-
* This may be added to an error's instancePath to show it add the violating property's control.
35+
* This may be added to an error's instancePath to show it at the violating property's control.
3636
* For example, for required property errors, the instancePath points to the object containing the required property.
3737
* The missing property's name is specified in the error's params.missingProperty field and returned by this function.
3838
*

packages/core/test/reducers/core.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2201,7 +2201,7 @@ test('getControlPath - nested required property', (t) => {
22012201
t.is(controlPath, 'parent.child');
22022202
});
22032203

2204-
test('getControlPath - prevents duplicate property when path already ends with property', (t) => {
2204+
test('getControlPath - same-named nested properties in different parent', (t) => {
22052205
const errorObject = {
22062206
instancePath: '/parent/child',
22072207
keyword: 'required',

packages/examples/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ import * as mixed from './examples/mixed';
7979
import * as mixedObject from './examples/mixed-object';
8080
import * as string from './examples/string';
8181
import * as prependAppendSlots from './examples/prepend-append-slots';
82-
import * as validationNestedSameNameValidation from './examples/validation-nested-same-name';
82+
import * as validationNestedSameName from './examples/validation-nested-same-name';
8383
export * from './register';
8484
export * from './example';
8585

@@ -148,5 +148,5 @@ export {
148148
arrayWithDefaults,
149149
string,
150150
prependAppendSlots,
151-
validationNestedSameNameValidation,
151+
validationNestedSameName,
152152
};

0 commit comments

Comments
 (0)